Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove empty balloons when inserting/editing utters #144

Open
5 tasks done
rodmaia opened this issue Feb 11, 2021 · 3 comments · May be fixed by #174
Open
5 tasks done

Remove empty balloons when inserting/editing utters #144

rodmaia opened this issue Feb 11, 2021 · 3 comments · May be fixed by #174
Assignees

Comments

@rodmaia
Copy link
Collaborator

rodmaia commented Feb 11, 2021

When inserting or editing an utter you can have balloons that are completely empty or that only have a [space] character inside. These balloons should be:

  • ignored by the front-end validation
  • not saved to the database
  • removed from the utter if present upon loading

A confirmation message should appear upon save saying "Balões vazios foram removidos".

With the exception of utters whose entire content is a single empty balloon. In that case, validation should continue preventing to save that utter.

Tasks

  • TBD

Acceptance criteria

  • Empty balloons are no longer present after saving
  • Empty balloons are not saved to the database
  • Empty balloons are not loaded from the database
  • Confirmation message is visible upon saving
@FranciscoHeronildo
Copy link
Collaborator

Working on a solution to this problem.

@rodmaia
Copy link
Collaborator Author

rodmaia commented Feb 19, 2021

@FranciscoHeronildo assign the issue to yourself if you are working on it 😉

Let me know if you can expose your dev environment to the web. I’d like to test it to ensure the original idea on the issue makes sense.

@Miguel-Alves
Copy link
Collaborator

I have concluded this issue.
Now, empty content is no longer saved or loaded to the database. And when saving or editing an utter, they are ignored by the front-end validation.
Also, there is a confirmation message displayed to user stating this removal of empty content

@Miguel-Alves Miguel-Alves linked a pull request Apr 8, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants