Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all LAPPIS and TAIS info from code #149

Open
rodmaia opened this issue Feb 11, 2021 · 8 comments
Open

Remove all LAPPIS and TAIS info from code #149

rodmaia opened this issue Feb 11, 2021 · 8 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@rodmaia
Copy link
Collaborator

rodmaia commented Feb 11, 2021

Originally, BotFlow was built coupled to LAPPIS' infrastructure and to TAIS' content. We should remove all those references in favor of:

  • a generic implementation where people can configure BotFlow to their infrastructures
  • default content used in rasa-ptbr-boilerplate

See also: #64 (comment)

@mansogf
Copy link
Collaborator

mansogf commented Feb 25, 2021

Following the procedures according to #153.

@rodmaia rodmaia added the documentation Improvements or additions to documentation label Mar 1, 2021
@mansogf
Copy link
Collaborator

mansogf commented Mar 2, 2021

@rodmaia , could you give me more details about this issue?

In my first shoot on it, I saw that we have some mentions about "TAIS" in the following file: BotFlowAPI/src/api/fixtures/initial.json.

Some examples can be visualized below:

{
        "model": "api.utter",
        "pk": 10,
        "fields": {
            "name": "utter_quem_criou_a_tais",
            "multiple_alternatives": true,
            "alternatives":[ 
                ["Fui desenvolvida pelo LAPPIS (Laboratório Avançado de Produção Pesquisa e Inovação em Software) na Universidade de Brasília, um laboratório super inovador e descolado!"],
                ["Se quiser me conhecer mais, acesse o meu projeto :) https://github.com/lappis-unb/tais"]

            ],
            "project": 1
        }
    }

or even,

{
        "model": "api.intent",
        "pk": 9,
        "fields": {
          "name": "quem_criou_a_tais",
          "samples": [
            "como você foi construida",
            "como voce foi construída",
            "quem te criou",
            "quem te desenvolveu",
            "quem te programou",
            "você tem pai",
            "qual seu pai",
            "onde voce nasceu",
            "quando vc nasceu",
            "quem te fez",
            "quem te produziu",
            "quem é seu pai",
            "fez a tais",
            "criou a tais",
            "produziu a tais",
            "desenvolveu a tais",
            "desenvolveu",
            "criou",
            "produziu",
            "programou"
          ],

        "project": 1
      }
    }

Then, my questions are:

  1. Would be this the target of this issue? If no, could you give me more examples from where I should give more attention?
  2. If yes, should I only delete all the intents and utters that mention LAPPIS and TAIS, or update them in a generical way?
  3. Does it have to consider a persona? I mean, does it need to have a personality?

@rodmaia
Copy link
Collaborator Author

rodmaia commented Mar 3, 2021

@gabrielfilipe7unb

  1. Yes, that is exactly the target of this issue.
  2. We should delete the current content and replace it with the example content from rasa-ptbr-boilerplate
  3. No it doesn't. We are not trying to create a full-fledged set of utters and intents. The goal here is to give BotFlow generic "starter set" content that anyone can customize later.

Think of it this way: you fork BotFlow, build it and run it for the first time. All you want is generic content that you can customize a couple of lines, export it and see it working on your bot. "LAPPIS", "Tais", "cultural incentive law" are all part of BotFlow history but only add confusion to the scenario.

BTW, we should target the default content and the rest of the code as well. Fore example, there might be some config info related to deployment on LAPPIS' infrastructure. That should be replaced by generic/configurable info.

@mansogf
Copy link
Collaborator

mansogf commented Mar 11, 2021

All "LAPPIS", "Tais" and "cultural incentive law" were removed and replaced by general content.

@mansogf
Copy link
Collaborator

mansogf commented Mar 11, 2021

All the LAPPIS' infrastructure content was removed.

@mansogf
Copy link
Collaborator

mansogf commented Mar 11, 2021

I need the authorization to push the code in the API repository.

@rodmaia
Copy link
Collaborator Author

rodmaia commented Mar 12, 2021

I granted access to to the whole team with the same permissions as in this repository

@mansogf
Copy link
Collaborator

mansogf commented Mar 17, 2021

Thanks, I just sent the PR (lappis-unb/BotFlowAPI#25).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants