-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Telescope throws an error since newest version #1579
Comments
See below json file of the error |
Hey there, thanks for reporting this issue. We'll need more info and/or code to debug this further. Can you please create a repository with the command below, commit the code that reproduces the issue as one separate commit on the main/master branch and share the repository here? Please make sure that you have the latest version of the Laravel installer in order to run this command. Please also make sure you have both Git & the GitHub CLI tool properly set up.
Do not amend and create a separate commit with your custom changes. After you've posted the repository, we'll try to reproduce the issue. Thanks! |
I'll make a project this weekend to reproduce. Thanks |
Hi @crynobone, I've done some further investigation... Creating a fresh project with Telescope installed did not reproduce this issue, so I went deeper into the code. However, I've identified the cause in our project: we have a custom Telescope::avatar(function (string $id, string $email) {
return User::find($id)->avatarURL;
}); In the latest version (v5.6.0), there is a change in how empty emails are checked. See v5.5.1...5.6.0 in src/Avatar.php. This change allows As a result, we encountered unexpected behavior where |
App\Providers\TelescopeServiceProvider::App\Providers{closure}(): Argument #1 ($id) must be of type string, null given
Telescope Version
5.6.0
Laravel Version
12.3.0
PHP Version
8.3.19
Database Driver & Version
No response
Description
Since the newest version of Telescope the following error occurs on all pages
Steps To Reproduce
No steps for reproducing, when downgrading to version 5.5.1 all works as normal again
The text was updated successfully, but these errors were encountered: