impl Executor for Transaction

[HaronK]

Hi guys,

I'm experimenting now with the latest alpha and it seems that Executor implementation for Transaction is disabled at the moment.

Is there any other way to execute query on transaction or should I wait until this is fixed?

[raine]

Is this the same problem? I cannot make querying with a transaction work no matter what I try.

pub async fn insert_product(product: &Product, pool: &sqlx::PgPool) -> Result<()> {
    let mut tx = pool.begin().await?;

    sqlx::query!(
        r#"
INSERT INTO product (name, url) VALUES ($1, $2)
        "#,
        product.name,
        product.url,
    )
    .execute(&tx)
    .await?;

    // ...

    |
14  |     .execute(&tx)
    |      ------- ^^^ the trait `Executor<'_>` is not implemented for `&Transaction<'_, Postgres>`
    |      |
    |      required by a bound introduced by this call
    |
    = help: the following other types implement trait `Executor<'c>`:
              <&'c mut AnyConnection as Executor<'c>>
              <&'c mut PgConnection as Executor<'c>>
              <&'c mut PgListener as Executor<'c>>
              <&Pool<DB> as Executor<'p>>
note: required by a bound in `Query::<'q, DB, A>::execute`
   --> /Users/raine/.cargo/registry/src/index.crates.io-6f17d22bba15001f/sqlx-core-0.7.1/src/query.rs:151:12
    |
151 |         E: Executor<'c, Database = DB>,
    |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^ required by this bound in `Query::<'q, DB, A>::execute`

For more information about this error, try `rustc --explain E0277`.
error: could not compile `bikeshopsearch-core` (lib) due to previous error

[raine]

@abonander I see you in git blame on that file linked by HaronK.

Was that commented impl<'c, 't, DB: Database> crate::executor::Executor<'t> block intended to be released in 0.7.x?

[HaronK]

In version 0.7.0 you have to use &mut *tx to get an executor. There was a comment in 0.7.0 release notes about that.