Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows: Fixes #11508: Prevent installer from recognizing itself as a running instance of Joplin #11540

Conversation

personalizedrefrigerator
Copy link
Collaborator

Summary

This pull request may fix #11508. It re-applies an electron-builder patch that seems to have been lost when upgrading Electron (in 2023). For additional details, see the pull request in which the patch was originally added.

If the patch does fix the issue, I plan open an upstream pull request with the change.

Testing plan

Note

I haven't been able to reproduce #11508 on my Windows 11 development virtual machine. The below steps are primarily to test for regressions.

Windows 11:

  1. Build Joplin Setup 3.2.5.exe using yarn dist from packages/app-desktop.
  2. Start Joplin if not already running.
  3. Run Joplin Setup 3.2.5.exe.
  4. Start installing Joplin for the local user.
  5. Verify that a "Joplin is running. \ Click OK to close it." dialog is shown.
  6. Click "OK".
  7. Verify that Joplin is closed.
  8. Wait for installation to complete.
  9. Leave "Run Joplin" checked.
  10. Click "Finish".
  11. Verify that Joplin starts.

@laurent22
Copy link
Owner

Now that #11541 has been merged, should we close this one?

@personalizedrefrigerator
Copy link
Collaborator Author

Yes. Let's close this pull request.

@mess-maker
Copy link

hi same issue on 3.2.6

@manderss99
Copy link

3.2.6 has same problem win11, cannot install.

@laurent22
Copy link
Owner

Please try manually uninstalling and installing again

@mess-maker
Copy link

3.2.10 installed (without prior uninstall)
had an error message saying that it cannot uninstall previous version, selected continue there, and the install has completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot install Joplin 3.2 on Windows
4 participants