Skip to content

Commit 8a3dae8

Browse files
committed
Update per comments
1 parent 7e05e43 commit 8a3dae8

File tree

4 files changed

+7
-5
lines changed

4 files changed

+7
-5
lines changed

examples/tv-app/android/java/TVApp-JNI.cpp

+3-3
Original file line numberDiff line numberDiff line change
@@ -240,15 +240,15 @@ class MyPincodeService : public PasscodeService
240240
};
241241
MyPincodeService gMyPincodeService;
242242

243-
class MyAppInstallationService : public AppInstallationService
243+
class SampleTvAppInstallationService : public AppInstallationService
244244
{
245245
bool LookupTargetContentApp(uint16_t vendorId, uint16_t productId) override
246246
{
247247
return ContentAppPlatform::GetInstance().LoadContentAppByClient(vendorId, productId) != nullptr;
248248
}
249249
};
250250

251-
MyAppInstallationService gMyAppInstallationService;
251+
SampleTvAppInstallationService gSampleTvAppInstallationService;
252252

253253
class MyPostCommissioningListener : public PostCommissioningListener
254254
{
@@ -382,7 +382,7 @@ void TvAppJNI::InitializeCommissioner(JNIMyUserPrompter * userPrompter)
382382
if (cdc != nullptr && userPrompter != nullptr)
383383
{
384384
cdc->SetPasscodeService(&gMyPincodeService);
385-
cdc->SetAppInstallationService(&gMyAppInstallationService);
385+
cdc->SetAppInstallationService(&gSampleTvAppInstallationService);
386386
cdc->SetUserPrompter(userPrompter);
387387
cdc->SetPostCommissioningListener(&gMyPostCommissioningListener);
388388
}

examples/tv-app/tv-common/include/AppTv.h

+2-1
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,8 @@ class DLL_EXPORT ContentAppFactoryImpl : public ContentAppFactory
150150
// Remove the app from the list of mContentApps
151151
bool UninstallContentApp(uint16_t vendorId, uint16_t productId);
152152
// Print mContentApps and endpoints
153-
void PrintInstalledApps();
153+
void LogInstalledApps();
154+
// TODO: method to retireve list of mContentApps
154155

155156
protected:
156157
std::vector<std::unique_ptr<ContentAppImpl>> mContentApps;

examples/tv-app/tv-common/src/AppTv.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -635,7 +635,7 @@ bool ContentAppFactoryImpl::UninstallContentApp(uint16_t vendorId, uint16_t prod
635635
return false;
636636
}
637637

638-
void ContentAppFactoryImpl::PrintInstalledApps()
638+
void ContentAppFactoryImpl::LogInstalledApps()
639639
{
640640
for (auto & contentApp : mContentApps)
641641
{

src/controller/CommissionerDiscoveryController.cpp

+1
Original file line numberDiff line numberDiff line change
@@ -231,6 +231,7 @@ void CommissionerDiscoveryController::InternalOk()
231231
ChipLogDetail(AppServer, "UX InternalOk: app not installed.");
232232

233233
// TODO: Prepare app to be installed or add it to the mContentApps
234+
// Draft PR: https://github.com/project-chip/connectedhomeip/pull/33982
234235
}
235236

236237
if (client->GetUDCClientProcessingState() != UDCClientProcessingState::kPromptingUser)

0 commit comments

Comments
 (0)