Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poster customization #400

Open
leepeuker opened this issue Jun 20, 2023 · 6 comments
Open

Poster customization #400

leepeuker opened this issue Jun 20, 2023 · 6 comments
Assignees
@JVT038
Labels
enhancement New feature or request

Comments

@leepeuker
Copy link
Owner

Currently the posters used for movies are the ones used at tmdb at the time of the data sync.

Users should have the option to manually choose which poster to use from the ones available at tmdb.

The available posters should be loaded dynamically from tmdb each time (some frontend caching could be useful).

Store the manually selected image url in the database. Image caching should use this one (cache directly on setting if enabled?).
@leepeuker leepeuker added the enhancement New feature or request label Jun 20, 2023
@JVT038
Copy link
Collaborator

JVT038 commented Jun 27, 2023

Maybe add an option for the users to manually upload their own poster?
Or maybe add an option for the users to enter an URL to an image (like https://imgur.com/mymovieposter.jpg) and have Movary process that?

@leepeuker
Copy link
Owner Author

Good idea, that should be possible too.

@JVT038
Copy link
Collaborator

JVT038 commented Jun 28, 2023

Which users should have the permissions to change the posters? Only the owners / admins or also regular users?

@leepeuker
Copy link
Owner Author

Hm, good question. I was thinking that every user should be able to change a movie poster for their context. So if you see a movie poster at the dashboard for user one it can be different to what it looks like on the dashboard of user two. This way everyone can customize it how they want and share there preferences with others.
A possible problem could be that it could be irritating when the same movie has different posters in different contexts 🤔 I am not sure yet what the best way is.
Maybe we could start with only admins being able to customize posters (globally) in the first step and add more control over it later?

@JVT038
Copy link
Collaborator

JVT038 commented Jun 28, 2023 •
edited
Loading

Maybe we could start with only admins being able to customize posters (globally) in the first step and add more control over it later?

Sounds like the way to go.
BTW, is there a proper permission system in Movary? As far as I know, there isn't a 'real' permission / role system right? Maybe we should add that to the roadmap as well.

@leepeuker
Copy link
Owner Author

The only difference is between admin and non admin users. I think that should be enough for now, at least I had no need for more roles. The implementation of it could probably be improved

@JVT038 JVT038 self-assigned this Oct 27, 2023
@JVT038 JVT038 linked a pull request Oct 27, 2023 that will close this issue
Change movie poster in the movie page #539
Closed
3 tasks
@JVT038 JVT038 mentioned this issue Jan 23, 2024
Open
74 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JVT038 JVT038

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change movie poster in the movie page leepeuker/movary
2 participants
@leepeuker @JVT038