Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD COMET_FORMAL_MODE option in config.sh #376

Closed

Conversation

fisuda
Copy link
Contributor

@fisuda fisuda commented May 28, 2024

Proposed changes

This PR adds COMET_FORMAL_MODE option in config.sh.

Types of changes

What types of changes does your code introduce to the project: Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update docker image version of FIWARE GE.
  • Update only documentation, not any source code.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • I have updated the change log (CHANGELOG.md)
  • I send this pull request to the v0.37.0-next branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

N/A

Copy link

codecov bot commented May 28, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 86.75%. Comparing base (16c2d83) to head (ffd4d4f).

Files Patch % Lines
CHANGELOG.md 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           v0.37.0-next     #376       +/-   ##
=================================================
- Coverage        100.00%   86.75%   -13.25%     
=================================================
  Files                 1        2        +1     
  Lines              1781     2054      +273     
=================================================
+ Hits               1781     1782        +1     
- Misses                0      272      +272     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fisuda fisuda force-pushed the feature/comet_formal_mode branch from a9bfcba to ffd4d4f Compare May 28, 2024 11:00
@fisuda fisuda closed this May 28, 2024
@fisuda fisuda deleted the feature/comet_formal_mode branch May 28, 2024 11:51
@github-actions github-actions bot locked and limited conversation to collaborators May 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant