Skip to content

Commit c63abbe

Browse files
committed
itest: query for all asset script types
To make sure our itests still work, we need to query assets with all possible script key types.
1 parent 5922abe commit c63abbe

File tree

5 files changed

+42
-15
lines changed

5 files changed

+42
-15
lines changed

itest/assertions.go

+12-2
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,12 @@ var (
4646

4747
batchFrozen = mintrpc.BatchState_BATCH_STATE_FROZEN
4848
batchFinalized = mintrpc.BatchState_BATCH_STATE_FINALIZED
49+
50+
allScriptKeysQuery = &taprpc.ScriptKeyTypeQuery{
51+
Type: &taprpc.ScriptKeyTypeQuery_AllTypes{
52+
AllTypes: true,
53+
},
54+
}
4955
)
5056

5157
// tapClient is an interface that covers all currently available RPC interfaces
@@ -1314,7 +1320,8 @@ func AssertBalanceByID(t *testing.T, client taprpc.TaprootAssetsClient,
13141320
GroupBy: &taprpc.ListBalancesRequest_AssetId{
13151321
AssetId: true,
13161322
},
1317-
AssetFilter: id,
1323+
AssetFilter: id,
1324+
ScriptKeyType: allScriptKeysQuery,
13181325
},
13191326
)
13201327
require.NoError(t, err)
@@ -1880,7 +1887,9 @@ func AssertAssetsMinted(t *testing.T, tapClient commands.RpcClientsBundle,
18801887
)
18811888

18821889
listRespConfirmed, err := tapClient.ListAssets(
1883-
ctxt, &taprpc.ListAssetRequest{},
1890+
ctxt, &taprpc.ListAssetRequest{
1891+
ScriptKeyType: allScriptKeysQuery,
1892+
},
18841893
)
18851894
require.NoError(t, err)
18861895
confirmedAssets := GroupAssetsByName(listRespConfirmed.Assets)
@@ -2176,6 +2185,7 @@ func assertNumAssetOutputs(t *testing.T, client taprpc.TaprootAssetsClient,
21762185

21772186
resp, err := client.ListAssets(ctxt, &taprpc.ListAssetRequest{
21782187
IncludeLeased: true,
2188+
ScriptKeyType: allScriptKeysQuery,
21792189
})
21802190
require.NoError(t, err)
21812191

itest/assets_test.go

+3-1
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,9 @@ func transferAssetProofs(t *harnessTest, src, dst *tapdHarness,
241241
}
242242

243243
listResp, err := dst.ListAssets(
244-
ctxt, &taprpc.ListAssetRequest{},
244+
ctxt, &taprpc.ListAssetRequest{
245+
ScriptKeyType: allScriptKeysQuery,
246+
},
245247
)
246248
require.NoError(t.t, err)
247249

itest/burn_test.go

+8-6
Original file line numberDiff line numberDiff line change
@@ -157,9 +157,10 @@ func testBurnAssets(t *harnessTest) {
157157

158158
// We'll now assert that the burned asset has the correct state.
159159
burnedAsset := burnResp.BurnProof.Asset
160-
allAssets, err := t.tapd.ListAssets(
161-
ctxt, &taprpc.ListAssetRequest{IncludeSpent: true},
162-
)
160+
allAssets, err := t.tapd.ListAssets(ctxt, &taprpc.ListAssetRequest{
161+
IncludeSpent: true,
162+
ScriptKeyType: allScriptKeysQuery,
163+
})
163164
require.NoError(t.t, err)
164165
AssertAssetStateByScriptKey(
165166
t.t, allAssets.Assets, burnedAsset.ScriptKey,
@@ -454,9 +455,10 @@ func testBurnGroupedAssets(t *harnessTest) {
454455

455456
// Ensure that the burnt asset has the correct state.
456457
burnedAsset := burnResp.BurnProof.Asset
457-
allAssets, err := t.tapd.ListAssets(
458-
ctxb, &taprpc.ListAssetRequest{IncludeSpent: true},
459-
)
458+
allAssets, err := t.tapd.ListAssets(ctxb, &taprpc.ListAssetRequest{
459+
IncludeSpent: true,
460+
ScriptKeyType: allScriptKeysQuery,
461+
})
460462
require.NoError(t.t, err)
461463
AssertAssetStateByScriptKey(
462464
t.t, allAssets.Assets, burnedAsset.ScriptKey,

itest/psbt_test.go

+18-6
Original file line numberDiff line numberDiff line change
@@ -874,7 +874,9 @@ func runPsbtInteractiveSplitSendTest(ctxt context.Context, t *harnessTest,
874874
)
875875

876876
senderAssets, err := sender.ListAssets(
877-
ctxt, &taprpc.ListAssetRequest{},
877+
ctxt, &taprpc.ListAssetRequest{
878+
ScriptKeyType: allScriptKeysQuery,
879+
},
878880
)
879881
require.NoError(t.t, err)
880882

@@ -898,7 +900,9 @@ func runPsbtInteractiveSplitSendTest(ctxt context.Context, t *harnessTest,
898900
require.Len(t.t, senderAssets.Assets, numSenderAssets)
899901

900902
receiverAssets, err := receiver.ListAssets(
901-
ctxt, &taprpc.ListAssetRequest{},
903+
ctxt, &taprpc.ListAssetRequest{
904+
ScriptKeyType: allScriptKeysQuery,
905+
},
902906
)
903907
require.NoError(t.t, err)
904908
require.Len(t.t, receiverAssets.Assets, numReceiverAssets)
@@ -1226,13 +1230,17 @@ func testPsbtInteractiveTapscriptSibling(t *harnessTest) {
12261230
)
12271231

12281232
senderAssets, err := alice.ListAssets(
1229-
ctxt, &taprpc.ListAssetRequest{},
1233+
ctxt, &taprpc.ListAssetRequest{
1234+
ScriptKeyType: allScriptKeysQuery,
1235+
},
12301236
)
12311237
require.NoError(t.t, err)
12321238
require.Len(t.t, senderAssets.Assets, 1)
12331239

12341240
receiverAssets, err := bob.ListAssets(
1235-
ctxt, &taprpc.ListAssetRequest{},
1241+
ctxt, &taprpc.ListAssetRequest{
1242+
ScriptKeyType: allScriptKeysQuery,
1243+
},
12361244
)
12371245
require.NoError(t.t, err)
12381246
require.Len(t.t, receiverAssets.Assets, 1)
@@ -1402,13 +1410,17 @@ func testPsbtMultiSend(t *harnessTest) {
14021410
)
14031411

14041412
senderAssets, err := sender.ListAssets(
1405-
ctxt, &taprpc.ListAssetRequest{},
1413+
ctxt, &taprpc.ListAssetRequest{
1414+
ScriptKeyType: allScriptKeysQuery,
1415+
},
14061416
)
14071417
require.NoError(t.t, err)
14081418
require.Len(t.t, senderAssets.Assets, 4)
14091419

14101420
receiverAssets, err := receiver.ListAssets(
1411-
ctxt, &taprpc.ListAssetRequest{},
1421+
ctxt, &taprpc.ListAssetRequest{
1422+
ScriptKeyType: allScriptKeysQuery,
1423+
},
14121424
)
14131425
require.NoError(t.t, err)
14141426
require.Len(t.t, receiverAssets.Assets, 2)

itest/utils.go

+1
Original file line numberDiff line numberDiff line change
@@ -403,6 +403,7 @@ func FinalizeBatchUnconfirmed(t *testing.T, minerClient *rpcclient.Client,
403403
listRespUnconfirmed, err := tapClient.ListAssets(
404404
ctxt, &taprpc.ListAssetRequest{
405405
IncludeUnconfirmedMints: true,
406+
ScriptKeyType: allScriptKeysQuery,
406407
},
407408
)
408409
require.NoError(t, err)

0 commit comments

Comments
 (0)