Skip to content

Commit e658d59

Browse files
Jiri Olsagregkh
Jiri Olsa
authored andcommitted
selftests/bpf: Fix perf_buffer test on system with offline cpus
[ Upstream commit d412137 ] The perf_buffer fails on system with offline cpus: # test_progs -t perf_buffer test_perf_buffer:PASS:nr_cpus 0 nsec test_perf_buffer:PASS:nr_on_cpus 0 nsec test_perf_buffer:PASS:skel_load 0 nsec test_perf_buffer:PASS:attach_kprobe 0 nsec test_perf_buffer:PASS:perf_buf__new 0 nsec test_perf_buffer:PASS:epoll_fd 0 nsec skipping offline CPU #24 skipping offline CPU #25 skipping offline CPU #26 skipping offline CPU #27 skipping offline CPU #28 skipping offline CPU #29 skipping offline CPU #30 skipping offline CPU #31 test_perf_buffer:PASS:perf_buffer__poll 0 nsec test_perf_buffer:PASS:seen_cpu_cnt 0 nsec test_perf_buffer:FAIL:buf_cnt got 24, expected 32 Summary: 0/0 PASSED, 0 SKIPPED, 1 FAILED Changing the test to check online cpus instead of possible. Signed-off-by: Jiri Olsa <jolsa@kernel.org> Signed-off-by: Andrii Nakryiko <andrii@kernel.org> Acked-by: John Fastabend <john.fastabend@gmail.com> Link: https://lore.kernel.org/bpf/20211021114132.8196-2-jolsa@kernel.org Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent d6dca06 commit e658d59

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

tools/testing/selftests/bpf/prog_tests/perf_buffer.c

+2-2
Original file line numberDiff line numberDiff line change
@@ -107,8 +107,8 @@ void test_perf_buffer(void)
107107
"expect %d, seen %d\n", nr_on_cpus, CPU_COUNT(&cpu_seen)))
108108
goto out_free_pb;
109109

110-
if (CHECK(perf_buffer__buffer_cnt(pb) != nr_cpus, "buf_cnt",
111-
"got %zu, expected %d\n", perf_buffer__buffer_cnt(pb), nr_cpus))
110+
if (CHECK(perf_buffer__buffer_cnt(pb) != nr_on_cpus, "buf_cnt",
111+
"got %zu, expected %d\n", perf_buffer__buffer_cnt(pb), nr_on_cpus))
112112
goto out_close;
113113

114114
for (i = 0; i < nr_cpus; i++) {

0 commit comments

Comments
 (0)