Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Talking noises #155

Open
skylord-a52 opened this issue Aug 2, 2022 · 0 comments
Open

Feature Request: Talking noises #155

skylord-a52 opened this issue Aug 2, 2022 · 0 comments

Comments

@skylord-a52
Copy link
Collaborator

skylord-a52 commented Aug 2, 2022

Something brought up in the discord was the idea of having little noises that play when somebody speaks.

Basic idea:

  • It sound repeat the same sound over and over but pitched randomly each time, potentially with the length of repetition corresponding to the length of the said phrase.
  • Each species should have one or two possible speech sounds -- the player can choose from any, organized by species, and slide the base pitch of their character's voice. Players are encouraged to choose speech sounds corresponding to their species but not required to.
  • There should be a toggleable option (and when we get around to redoing the sound settings, a slider) to disable speech sounds client-side.

A few details, more optional/edge-casey:

  • The final sound of a question mark should be higher pitched, to imitate the rising tone of a question
  • Cyborgs should have about half as much tone variation as others
  • Characters that use sign language should not make speech sounds (obviously)
  • Plasmans should make xylophone and/or bone-rattling noises.
  • Breathing helium should raise your voice by one octave.

Some questions that will need to be answered:

  • How will whispering be handled? No sound? A quiet version of the player's speech sound? A special whisper sfx? I'm thinking no sound but I'm not sure.
  • If you're out of line of sight (how speech visibility is normally handled) can you still hear speech sfx? Notably, you can still hear/see footprints even outside of line of sight, so it wouldn't be completely inconsistent with how sounds already work. Hearing ominous but not understandable voices coming from the maintenance next your department would be a very interesting quirk of this, I think.

Some helpful previous PRs with code to steal:

TTS: tgstation#68106
Speech sounds: tgstation#49042

I'd be totally up for making the sounds myself and working to make the implementation sound good, but I'm not going to do the base system myself. I need a break from BYOND at the moment, and this seems like the sort of thing that would need a lot of datum and component fuckery, which I wouldn't know how to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant