Skip to content

Commit 1e2ea13

Browse files
authored
[CIR][CIRGen][Builtin] Add skeleton for missing builtin entries. (NFC) (#1552)
These entries exist in OG but are not present in CIR codegen.
1 parent 424918e commit 1e2ea13

File tree

1 file changed

+57
-4
lines changed

1 file changed

+57
-4
lines changed

clang/lib/CIR/CodeGen/CIRGenBuiltin.cpp

+57-4
Original file line numberDiff line numberDiff line change
@@ -673,6 +673,16 @@ RValue CIRGenFunction::emitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID,
673673
case Builtin::BI__builtin_atanf128:
674674
llvm_unreachable("Builtin::BIatan like NYI");
675675

676+
case Builtin::BIatan2:
677+
case Builtin::BIatan2f:
678+
case Builtin::BIatan2l:
679+
case Builtin::BI__builtin_atan2:
680+
case Builtin::BI__builtin_atan2f:
681+
case Builtin::BI__builtin_atan2f16:
682+
case Builtin::BI__builtin_atan2l:
683+
case Builtin::BI__builtin_atan2f128:
684+
llvm_unreachable("Builtin::BIatan2 like NYI");
685+
676686
case Builtin::BIceil:
677687
case Builtin::BIceilf:
678688
case Builtin::BIceill:
@@ -801,6 +811,26 @@ RValue CIRGenFunction::emitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID,
801811
case Builtin::BI__builtin_fminf128:
802812
llvm_unreachable("BI__builtin_fminf16 like NYI");
803813

814+
case Builtin::BIfmaximum_num:
815+
case Builtin::BIfmaximum_numf:
816+
case Builtin::BIfmaximum_numl:
817+
case Builtin::BI__builtin_fmaximum_num:
818+
case Builtin::BI__builtin_fmaximum_numf:
819+
case Builtin::BI__builtin_fmaximum_numf16:
820+
case Builtin::BI__builtin_fmaximum_numl:
821+
case Builtin::BI__builtin_fmaximum_numf128:
822+
llvm_unreachable("Builtin::BIfmaximum_num like NYI");
823+
824+
case Builtin::BIfminimum_num:
825+
case Builtin::BIfminimum_numf:
826+
case Builtin::BIfminimum_numl:
827+
case Builtin::BI__builtin_fminimum_num:
828+
case Builtin::BI__builtin_fminimum_numf:
829+
case Builtin::BI__builtin_fminimum_numf16:
830+
case Builtin::BI__builtin_fminimum_numl:
831+
case Builtin::BI__builtin_fminimum_numf128:
832+
llvm_unreachable("Builtin::BIfminimum_num like NYI");
833+
804834
// fmod() is a special-case. It maps to the frem instruction rather than an
805835
// LLVM intrinsic.
806836
case Builtin::BIfmod:
@@ -914,6 +944,31 @@ RValue CIRGenFunction::emitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID,
914944
assert(!cir::MissingFeatures::fastMathFlags());
915945
return emitUnaryMaybeConstrainedFPBuiltin<cir::SinOp>(*this, *E);
916946

947+
case Builtin::BIsinh:
948+
case Builtin::BIsinhf:
949+
case Builtin::BIsinhl:
950+
case Builtin::BI__builtin_sinh:
951+
case Builtin::BI__builtin_sinhf:
952+
case Builtin::BI__builtin_sinhf16:
953+
case Builtin::BI__builtin_sinhl:
954+
case Builtin::BI__builtin_sinhf128:
955+
llvm_unreachable("Builtin::BIsinh like NYI");
956+
957+
case Builtin::BI__builtin_sincospi:
958+
case Builtin::BI__builtin_sincospif:
959+
case Builtin::BI__builtin_sincospil:
960+
llvm_unreachable("Builtin::BI__builtin_sincospi like NYI");
961+
962+
case Builtin::BIsincos:
963+
case Builtin::BIsincosf:
964+
case Builtin::BIsincosl:
965+
case Builtin::BI__builtin_sincos:
966+
case Builtin::BI__builtin_sincosf:
967+
case Builtin::BI__builtin_sincosf16:
968+
case Builtin::BI__builtin_sincosl:
969+
case Builtin::BI__builtin_sincosf128:
970+
llvm_unreachable("Builtin::BIsincos like NYI");
971+
917972
case Builtin::BIsqrt:
918973
case Builtin::BIsqrtf:
919974
case Builtin::BIsqrtl:
@@ -1440,9 +1495,8 @@ RValue CIRGenFunction::emitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID,
14401495
mlir::Value result = call->getResult(0);
14411496
return RValue::get(result);
14421497
}
1443-
case Builtin::BI__builtin_elementwise_acos: {
1498+
case Builtin::BI__builtin_elementwise_acos:
14441499
return emitUnaryFPBuiltin<cir::ACosOp>(*this, *E);
1445-
}
14461500
case Builtin::BI__builtin_elementwise_asin:
14471501
return emitUnaryFPBuiltin<cir::ASinOp>(*this, *E);
14481502
case Builtin::BI__builtin_elementwise_atan:
@@ -1451,9 +1505,8 @@ RValue CIRGenFunction::emitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID,
14511505
llvm_unreachable("BI__builtin_elementwise_atan2 NYI");
14521506
case Builtin::BI__builtin_elementwise_ceil:
14531507
llvm_unreachable("BI__builtin_elementwise_ceil NYI");
1454-
case Builtin::BI__builtin_elementwise_exp: {
1508+
case Builtin::BI__builtin_elementwise_exp:
14551509
return emitUnaryFPBuiltin<cir::ExpOp>(*this, *E);
1456-
}
14571510
case Builtin::BI__builtin_elementwise_exp2:
14581511
llvm_unreachable("BI__builtin_elementwise_exp2 NYI");
14591512
case Builtin::BI__builtin_elementwise_log:

0 commit comments

Comments
 (0)