fix: disable write options on popup menu for a readonly video

lzls · lzls · commit e9f757a47284 · 2023-03-22T19:34:44.000+08:00
diff --git a/app/src/main/java/com/liuzhenlin/videos/view/fragment/LocalSearchedVideosFragment.kt b/app/src/main/java/com/liuzhenlin/videos/view/fragment/LocalSearchedVideosFragment.kt
@@ -235,6 +235,8 @@ class LocalSearchedVideosFragment : BaseFragment(), View.OnClickListener, View.O
 
         mVideoOptionsMenu = FloatingMenu(mRecyclerView)
         mVideoOptionsMenu!!.inflate(R.menu.floatingmenu_video_ops)
+        mVideoOptionsMenu!!.setItemEnabled(R.id.delete, video.isWritable)
+        mVideoOptionsMenu!!.setItemEnabled(R.id.rename, video.isWritable)
         mVideoOptionsMenu!!.setOnItemClickListener { menuItem, _ ->
             when (menuItem.iconResId) {
                 R.drawable.ic_delete_24dp_menu -> mVideoOpCallback?.showDeleteItemDialog(video) {
diff --git a/app/src/main/java/com/liuzhenlin/videos/view/fragment/OnlineVideosFragment.kt b/app/src/main/java/com/liuzhenlin/videos/view/fragment/OnlineVideosFragment.kt
@@ -22,6 +22,7 @@ import com.liuzhenlin.common.utils.UiUtils
 import com.liuzhenlin.common.utils.Utils
 import com.liuzhenlin.common.view.SwipeRefreshLayout
 import com.liuzhenlin.floatingmenu.FloatingMenu
+import com.liuzhenlin.floatingmenu.MenuItem
 import com.liuzhenlin.slidingdrawerlayout.SlidingDrawerLayout
 import com.liuzhenlin.videos.R
 import com.liuzhenlin.videos.bean.TV
@@ -264,7 +265,7 @@ class OnlineVideosFragment : Fragment(), SlidingDrawerLayout.OnDrawerScrollListe
                 getChildView(groupPosition, childPosition, false /* ignored */, view, parent)
 
                 val fm = FloatingMenu(view)
-                fm.items(getString(R.string.copyURL))
+                fm.items(Collections.singletonList(MenuItem(View.NO_ID, getString(R.string.copyURL))))
                 fm.show(mDownX, mDownY)
                 fm.setOnItemClickListener { _, _ ->
                     Utils.copyPlainTextToClipboard(parent.context, child.name, child.url)
diff --git a/app/src/main/res/color/color_selector_menu_gray_video_option_btn.xml b/app/src/main/res/color/color_selector_menu_gray_video_option_btn.xml
@@ -0,0 +1,5 @@
+<?xml version="1.0" encoding="utf-8"?>
+<selector xmlns:android="http://schemas.android.com/apk/res/android">
+    <item android:color="@color/grayVideoOptionBtnColor" android:state_enabled="true" />
+    <item android:color="@color/grayVideoOptionBtnColor_translucent" />
+</selector>
diff --git a/app/src/main/res/drawable/ic_delete_24dp_menu.xml b/app/src/main/res/drawable/ic_delete_24dp_menu.xml
@@ -6,6 +6,6 @@
     android:viewportHeight="24">
 
     <path
-        android:fillColor="@color/grayVideoOptionBtnColor"
+        android:fillColor="@color/color_selector_menu_gray_video_option_btn"
         android:pathData="M16,9v10H8V9h8m-1.5,-6h-5l-1,1H5v2h14V4h-3.5l-1,-1zM18,7H6v12c0,1.1 0.9,2 2,2h8c1.1,0 2,-0.9 2,-2V7z" />
 </vector>
diff --git a/app/src/main/res/drawable/ic_edit_24dp_menu.xml b/app/src/main/res/drawable/ic_edit_24dp_menu.xml
@@ -6,6 +6,6 @@
     android:viewportHeight="24">
 
     <path
-        android:fillColor="@color/grayVideoOptionBtnColor"
+        android:fillColor="@color/color_selector_menu_gray_video_option_btn"
         android:pathData="M14.06,9.02l0.92,0.92L5.92,19L5,19v-0.92l9.06,-9.06M17.66,3c-0.25,0 -0.51,0.1 -0.7,0.29l-1.83,1.83 3.75,3.75 1.83,-1.83c0.39,-0.39 0.39,-1.02 0,-1.41l-2.34,-2.34c-0.2,-0.2 -0.45,-0.29 -0.71,-0.29zM14.06,6.19L3,17.25L3,21h3.75L17.81,9.94l-3.75,-3.75z" />
 </vector>
diff --git a/app/src/main/res/drawable/ic_info_24dp_menu.xml b/app/src/main/res/drawable/ic_info_24dp_menu.xml
@@ -6,6 +6,6 @@
     android:viewportHeight="24">
 
     <path
-        android:fillColor="@color/grayVideoOptionBtnColor"
+        android:fillColor="@color/color_selector_menu_gray_video_option_btn"
         android:pathData="M11,7h2v2h-2zM11,11h2v6h-2zM12,2C6.48,2 2,6.48 2,12s4.48,10 10,10 10,-4.48 10,-10S17.52,2 12,2zM12,20c-4.41,0 -8,-3.59 -8,-8s3.59,-8 8,-8 8,3.59 8,8 -3.59,8 -8,8z" />
 </vector>
diff --git a/app/src/main/res/drawable/ic_share_24dp_menu.xml b/app/src/main/res/drawable/ic_share_24dp_menu.xml
@@ -6,6 +6,6 @@
     android:viewportHeight="24">
 
     <path
-        android:fillColor="@color/grayVideoOptionBtnColor"
+        android:fillColor="@color/color_selector_menu_gray_video_option_btn"
         android:pathData="M18,16.08c-0.76,0 -1.44,0.3 -1.96,0.77L8.91,12.7c0.05,-0.23 0.09,-0.46 0.09,-0.7s-0.04,-0.47 -0.09,-0.7l7.05,-4.11c0.54,0.5 1.25,0.81 2.04,0.81 1.66,0 3,-1.34 3,-3s-1.34,-3 -3,-3 -3,1.34 -3,3c0,0.24 0.04,0.47 0.09,0.7L8.04,9.81C7.5,9.31 6.79,9 6,9c-1.66,0 -3,1.34 -3,3s1.34,3 3,3c0.79,0 1.5,-0.31 2.04,-0.81l7.12,4.16c-0.05,0.21 -0.08,0.43 -0.08,0.65 0,1.61 1.31,2.92 2.92,2.92s2.92,-1.31 2.92,-2.92c0,-1.61 -1.31,-2.92 -2.92,-2.92zM18,4c0.55,0 1,0.45 1,1s-0.45,1 -1,1 -1,-0.45 -1,-1 0.45,-1 1,-1zM6,13c-0.55,0 -1,-0.45 -1,-1s0.45,-1 1,-1 1,0.45 1,1 -0.45,1 -1,1zM18,20.02c-0.55,0 -1,-0.45 -1,-1s0.45,-1 1,-1 1,0.45 1,1 -0.45,1 -1,1z" />
 </vector>
diff --git a/app/src/main/res/menu/floatingmenu_video_ops.xml b/app/src/main/res/menu/floatingmenu_video_ops.xml
@@ -1,22 +1,21 @@
 <?xml version="1.0" encoding="utf-8"?>
 <menu xmlns:android="http://schemas.android.com/apk/res/android"
     xmlns:tools="http://schemas.android.com/tools"
-    xmlns:app="http://schemas.android.com/apk/res-auto"
     tools:ignore="MenuTitle">
     <item
         android:id="@+id/delete"
-        app:text="@string/delete"
-        app:icon="@drawable/ic_delete_24dp_menu" />
+        android:text="@string/delete"
+        android:icon="@drawable/ic_delete_24dp_menu" />
     <item
         android:id="@+id/rename"
-        app:text="@string/rename"
-        app:icon="@drawable/ic_edit_24dp_menu" />
+        android:text="@string/rename"
+        android:icon="@drawable/ic_edit_24dp_menu" />
     <item
         android:id="@+id/share"
-        app:text="@string/share"
-        app:icon="@drawable/ic_share_24dp_menu" />
+        android:text="@string/share"
+        android:icon="@drawable/ic_share_24dp_menu" />
     <item
         android:id="@+id/details"
-        app:text="@string/details"
-        app:icon="@drawable/ic_info_24dp_menu" />
+        android:text="@string/details"
+        android:icon="@drawable/ic_info_24dp_menu" />
 </menu>
diff --git a/floating-menu/src/main/java/com/liuzhenlin/floatingmenu/FloatingMenu.java b/floating-menu/src/main/java/com/liuzhenlin/floatingmenu/FloatingMenu.java
@@ -162,31 +162,18 @@ private void parseMenu(XmlPullParser parser, AttributeSet attrs)
 
     private void readItem(AttributeSet attrs) {
         TypedArray ta = mContext.obtainStyledAttributes(attrs, R.styleable.MenuItem);
-        final int iconResId = ta.getResourceId(R.styleable.MenuItem_icon, 0);
-        final String text = ta.getText(R.styleable.MenuItem_text).toString();
+        final int id = ta.getResourceId(R.styleable.MenuItem_android_id, View.NO_ID);
+        final int iconResId = ta.getResourceId(R.styleable.MenuItem_android_icon, 0);
+        final String text = ta.getText(R.styleable.MenuItem_android_text).toString();
+        final boolean enabled = ta.getBoolean(R.styleable.MenuItem_android_enabled, true);
         ta.recycle();
 
-        MenuItem item = new MenuItem();
-        item.setIconResId(iconResId);
-        item.setText(text);
+        MenuItem item = new MenuItem(id, text, iconResId);
+        item.setEnabled(enabled);
 
         mMenuItems.add(item);
     }
 
-    public void items(@Nullable String... items) {
-        items(DEFAULT_ITEM_WIDTH, items);
-    }
-
-    public void items(int itemWidth, @Nullable String... items) {
-        mMenuItems.clear();
-        if (items != null) {
-            for (String item : items) {
-                mMenuItems.add(new MenuItem(item));
-            }
-        }
-        generateLayout(itemWidth);
-    }
-
     public <T extends MenuItem> void items(@Nullable List<T> items) {
         items(items, DEFAULT_ITEM_WIDTH);
     }
@@ -211,6 +198,8 @@ private void generateLayout(int itemWidth) {
             MenuItem menuItem = mMenuItems.get(i);
 
             TextView textView = new TextView(mContext);
+            textView.setId(menuItem.getId());
+            textView.setEnabled(menuItem.isEnabled());
             textView.setLayoutParams(new LinearLayout.LayoutParams(
                     itemWidth, ViewGroup.LayoutParams.WRAP_CONTENT));
             ViewCompat.setPaddingRelative(textView, padding, padding, padding * 2, padding);
@@ -222,7 +211,7 @@ private void generateLayout(int itemWidth) {
             textView.setTextSize(15);
             //noinspection RestrictedApi
             textView.setTextColor(
-                    ThemeUtils.getThemeAttrColor(mContext, android.R.attr.textColorPrimary));
+                    ThemeUtils.getThemeAttrColorStateList(mContext, android.R.attr.textColorPrimary));
             if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN_MR1) {
                 textView.setTextAlignment(View.TEXT_ALIGNMENT_VIEW_START);
             }
@@ -260,6 +249,14 @@ private void generateLayout(int itemWidth) {
         setContentView(menuLayout);
     }
 
+    public boolean isItemEnabled(int id) {
+        return getContentView().findViewById(id).isEnabled();
+    }
+
+    public void setItemEnabled(int id, boolean enabled) {
+        getContentView().findViewById(id).setEnabled(enabled);
+    }
+
     public void show(int x, int y) {
         mDownX = x;
         mDownY = y;
diff --git a/floating-menu/src/main/java/com/liuzhenlin/floatingmenu/MenuItem.java b/floating-menu/src/main/java/com/liuzhenlin/floatingmenu/MenuItem.java
@@ -1,24 +1,38 @@
 package com.liuzhenlin.floatingmenu;
 
+import android.view.View;
+
 import androidx.annotation.NonNull;
 
 public class MenuItem {
 
+    private int id = View.NO_ID;
     private CharSequence text;
     private int iconResId;
+    private boolean enabled = true;
 
     public MenuItem() {
     }
 
-    public MenuItem(String text) {
+    public MenuItem(int id, String text) {
+        this.id = id;
         this.text = text;
     }
 
-    public MenuItem(String text, int iconResId) {
+    public MenuItem(int id, String text, int iconResId) {
+        this.id = id;
         this.text = text;
         this.iconResId = iconResId;
     }
 
+    public int getId() {
+        return id;
+    }
+
+    public void setId(int id) {
+        this.id = id;
+    }
+
     public CharSequence getText() {
         return text;
     }
@@ -35,11 +49,21 @@ public void setIconResId(int itemResId) {
         this.iconResId = itemResId;
     }
 
+    public boolean isEnabled() {
+        return enabled;
+    }
+
+    public void setEnabled(boolean enabled) {
+        this.enabled = enabled;
+    }
+
     @NonNull
     @Override
     public String toString() {
         return "MenuItem{" +
-                "text='" + text + '\'' +
+                "id=" + id + ", " +
+                "text='" + text + "', " +
+                "enabled=" + enabled +
                 '}';
     }
 }
diff --git a/floating-menu/src/main/res/values/attrs.xml b/floating-menu/src/main/res/values/attrs.xml
@@ -1,7 +1,9 @@
 <?xml version="1.0" encoding="utf-8"?>
 <resources>
     <declare-styleable name="MenuItem">
-        <attr name="text" format="string" />
-        <attr name="icon" format="reference" />
+        <attr name="android:id" />
+        <attr name="android:text" />
+        <attr name="android:icon" />
+        <attr name="android:enabled" />
     </declare-styleable>
 </resources>
