[diag] Handle errors of TransmitPacket()

`TransmitPacket()` should return an error from platform Radio
implementation, as for example Radio can be in incorrect state.

If error occurs, output it onto console.

Add wrong state case to tests and fix `diag repeat stop` called
too lata.

Signed-off-by: Maciej Baczmanski <maciej.baczmanski@nordicsemi.no>

Author: maciejbaczmanski

src/core/diags/factory_diags.cpp

@@ -457,9 +457,9 @@ Error Diags::ProcessSend(uint8_t aArgsLength, char *aArgs[])
     VerifyOrExit(txLength >= OT_RADIO_FRAME_MIN_SIZE, error = kErrorInvalidArgs);
     mTxLen = txLength;
 
-    Output("sending %#x packet(s), length %#x\r\n", static_cast<int>(mTxPackets), static_cast<int>(mTxLen));
-    TransmitPacket();
+    SuccessOrExit(error = TransmitPacket());
 
+    Output("sending %#x packet(s), length %#x\r\n", static_cast<int>(mTxPackets), static_cast<int>(mTxLen));
 exit:
     return error;
 }
@@ -537,7 +537,7 @@ Error Diags::ProcessStop(uint8_t aArgsLength, char *aArgs[])
     return kErrorNone;
 }
 
-void Diags::TransmitPacket(void)
+Error Diags::TransmitPacket(void)
 {
     mTxPacket->mChannel = mChannel;
 
@@ -559,7 +559,7 @@ void Diags::TransmitPacket(void)
     }
 
     mDiagSendOn = true;
-    IgnoreError(Get<Radio>().Transmit(*static_cast<Mac::TxFrame *>(mTxPacket)));
+    return Get<Radio>().Transmit(*static_cast<Mac::TxFrame *>(mTxPacket));
 }
 
 Error Diags::ParseReceiveConfigFormat(const char *aFormat, ReceiveConfig &aConfig)
@@ -758,7 +758,11 @@ void Diags::AlarmFired(void)
     {
         uint32_t now = otPlatAlarmMilliGetNow();
 
-        TransmitPacket();
+        Error error = TransmitPacket();
+        if (error != kErrorNone)
+        {
+            Output("Packet transmission failed\r\nstatus %#x\r\n", error);
+        }
         otPlatAlarmMilliStartAt(&GetInstance(), now, mTxPeriod);
     }
     else
@@ -841,6 +845,8 @@ void Diags::ReceiveDone(otRadioFrame *aFrame, Error aError)
 
 void Diags::TransmitDone(Error aError)
 {
+    Error error;
+
     VerifyOrExit(mDiagSendOn);
     mDiagSendOn = false;
 
@@ -859,7 +865,11 @@ void Diags::TransmitDone(Error aError)
     }
 
     VerifyOrExit(!mRepeatActive);
-    TransmitPacket();
+    error = TransmitPacket();
+    if (error != kErrorNone)
+    {
+        Output("Packet transmission failed\r\nstatus %#x\r\n", error);
+    }
 
 exit:
     return;

src/core/diags/factory_diags.hpp

@@ -228,10 +228,10 @@ class Diags : public InstanceLocator, private NonCopyable
     Error GetPowerSettings(uint8_t aChannel, PowerSettings &aPowerSettings);
     Error ParseReceiveConfigFormat(const char *aFormat, ReceiveConfig &aConfig);
     Error RadioReceive(void);
+    Error TransmitPacket(void);
     void  OutputReceivedFrame(const otRadioFrame *aFrame);
     bool  ShouldHandleReceivedFrame(const otRadioFrame &aFrame) const;
 
-    void TransmitPacket(void);
     void Output(const char *aFormat, ...);
     void AppendErrorResult(Error aError);
     void ResetTxPacket(void);

tests/scripts/expect/cli-diags.exp

@@ -130,6 +130,24 @@ send_user "input odd length test\n"
 send "diag frame 123\n"
 expect "Error"
 
+send "diag radio sleep\n"
+expect_line "Done"
+
+send "diag radio disable\n"
+expect_line "Done"
+
+send "diag send 10 10\n"
+expect "failed"
+expect "status 0xd"
+expect "Error 13: InvalidState"
+
+send "diag radio enable\n"
+expect_line "Done"
+
+send "diag radio receive\n"
+expect "set radio from sleep to receive on channel 20"
+expect_line "Done"
+
 send_user "shortest frame test\n"
 send "diag frame 112233\n"
 expect "Done"
@@ -143,6 +161,9 @@ expect "Done"
 send "diag repeat 1\n"
 expect "length 0x7f"
 expect "Done"
+sleep 3
+send "diag repeat stop\n"
+expect "Done"
 
 send_user "send frame with security processed\n"
 send "diag frame -s 112233\n"
@@ -165,9 +186,6 @@ send "diag send 1\n"
 expect "length 0x3"
 expect "Done"
 
-send "diag repeat stop\n"
-expect "Done"
-
 send "diag channel 11\n"
 expect "set channel to 11"
 expect_line "Done"