Update various bits to c++17 and gnu++17. (project-chip#28280)

bzbarsky-apple · web-flow · commit 67324e6f593a · 2023-07-26T04:46:22.000Z
A number of gnu++14/c++14/c++11/gnu++11 got missed.
diff --git a/.vscode/c_cpp_properties.json b/.vscode/c_cpp_properties.json
@@ -5,7 +5,7 @@
             "compileCommands": "${workspaceFolder}/out/debug/compile_commands.gcc.json",
             "compilerPath": "/usr/bin/gcc",
             "cStandard": "c11",
-            "cppStandard": "gnu++14",
+            "cppStandard": "gnu++17",
             "intelliSenseMode": "gcc-x64",
             "browse": {
                 "path": ["${workspaceFolder}/out/debug/"],
@@ -17,7 +17,7 @@
             "compileCommands": "${workspaceFolder}/out/debug/compile_commands.clang.json",
             "compilerPath": "/usr/bin/clang",
             "cStandard": "c11",
-            "cppStandard": "gnu++14",
+            "cppStandard": "gnu++17",
             "intelliSenseMode": "clang-x64",
             "browse": {
                 "path": ["${workspaceFolder}/out/debug/"],
@@ -29,7 +29,7 @@
             "compileCommands": "${workspaceFolder}/out/debug/compile_commands.mbedtls.json",
             "compilerPath": "/usr/bin/gcc",
             "cStandard": "c11",
-            "cppStandard": "gnu++14",
+            "cppStandard": "gnu++17",
             "intelliSenseMode": "gcc-x64",
             "browse": {
                 "path": ["${workspaceFolder}/out/debug/"],
@@ -39,7 +39,7 @@
         {
             "name": "Android x64 debug (GN)",
             "cStandard": "c11",
-            "cppStandard": "c++11",
+            "cppStandard": "gnu++17",
             "intelliSenseMode": "clang-x64",
             "compileCommands": "${workspaceFolder}/out/debug/compile_commands.android_x64.json",
             "compilerPath": "/opt/android/android-ndk-r21b/toolchains/llvm/prebuilt/linux-x86_64/bin/x86_64-linux-android24-clang",
@@ -51,7 +51,7 @@
         {
             "name": "Android arm64 debug (GN)",
             "cStandard": "c11",
-            "cppStandard": "c++11",
+            "cppStandard": "gnu++17",
             "intelliSenseMode": "clang-arm64",
             "compileCommands": "${workspaceFolder}/out/debug/compile_commands.android_arm64.json",
             "compilerPath": "/opt/android/android-ndk-r21b/toolchains/llvm/prebuilt/linux-x86_64/bin/aarch64-linux-android24-clang",
@@ -63,7 +63,7 @@
         {
             "name": "EFR32 examples debug (GN)",
             "cStandard": "c11",
-            "cppStandard": "c++11",
+            "cppStandard": "gnu++17",
             "intelliSenseMode": "gcc-arm",
             "compileCommands": "${workspaceFolder}/out/debug/compile_commands.efr32.json",
             "compilerPath": "/opt/ARM-software/gcc-arm-none-eabi-9-2019-q4-major/bin/arm-none-eabi-gcc",
@@ -75,7 +75,7 @@
         {
             "name": "nRF Connect examples debug (GN)",
             "cStandard": "c11",
-            "cppStandard": "gnu++14",
+            "cppStandard": "gnu++17",
             "intelliSenseMode": "gcc-arm",
             "compilerPath": "/opt/ARM-software/gcc-arm-none-eabi-9-2019-q4-major/bin/arm-none-eabi-gcc",
             "browse": {
@@ -86,7 +86,7 @@
         {
             "name": "Tizen examples debug (GN)",
             "cStandard": "c11",
-            "cppStandard": "gnu++14",
+            "cppStandard": "gnu++17",
             "intelliSenseMode": "gcc-arm",
             "compilerPath": "/opt/tizen-sdk/tools/arm-linux-gnueabi-gcc-9.2/bin/arm-linux-gnueabi-gcc",
             "compileCommands": "${workspaceFolder}/out/debug/compile_commands.tizen_arm.json",
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -166,7 +166,7 @@
     ],
     "clang-format.fallbackStyle": "WebKit",
     "files.trimFinalNewlines": true,
-    "C_Cpp.default.cppStandard": "gnu++14",
+    "C_Cpp.default.cppStandard": "gnu++17",
     "C_Cpp.default.cStandard": "gnu11",
     "cmake.configureOnOpen": false,
     "search.followSymlinks": false,
diff --git a/examples/all-clusters-app/ameba/chip_main.cmake b/examples/all-clusters-app/ameba/chip_main.cmake
@@ -298,8 +298,7 @@ list(
     APPEND chip_main_cpp_flags
 
 	-Wno-unused-parameter
-	-std=gnu++11
-	-std=c++14
+	-std=c++17
 	-fno-rtti
 )
 target_compile_definitions(${chip_main} PRIVATE ${chip_main_flags} )
diff --git a/examples/all-clusters-minimal-app/ameba/chip_main.cmake b/examples/all-clusters-minimal-app/ameba/chip_main.cmake
@@ -258,8 +258,7 @@ list(
     APPEND chip_main_cpp_flags
 
 	-Wno-unused-parameter
-	-std=gnu++11
-	-std=c++14
+	-std=c++17
 	-fno-rtti
 )
 target_compile_definitions(${chip_main} PRIVATE ${chip_main_flags} )
diff --git a/examples/bridge-app/esp32/CMakeLists.txt b/examples/bridge-app/esp32/CMakeLists.txt
@@ -29,7 +29,7 @@ set(EXTRA_COMPONENT_DIRS
 
 # TODO: add CHIPProjectAppConfig.h to esp32
 project(chip-bridge-app)
-idf_build_set_property(CXX_COMPILE_OPTIONS "-std=gnu++14;-Os;-DCHIP_HAVE_CONFIG_H;-DCHIP_DEVICE_CONFIG_DYNAMIC_ENDPOINT_COUNT=16" APPEND)
+idf_build_set_property(CXX_COMPILE_OPTIONS "-std=gnu++17;-Os;-DCHIP_HAVE_CONFIG_H;-DCHIP_DEVICE_CONFIG_DYNAMIC_ENDPOINT_COUNT=16" APPEND)
 idf_build_set_property(C_COMPILE_OPTIONS "-Os" APPEND)
 # For the C3, project_include.cmake sets -Wno-format, but does not clear various
 # flags that depend on -Wformat
diff --git a/examples/chef/ameba/chip_main.cmake b/examples/chef/ameba/chip_main.cmake
@@ -114,8 +114,7 @@ list(
     APPEND chip_main_cpp_flags
 
 	-Wno-unused-parameter
-	-std=gnu++11
-	-std=c++14
+	-std=c++17
 	-fno-rtti
 )
 target_compile_definitions(${chip_main} PRIVATE ${chip_main_flags} )
diff --git a/examples/light-switch-app/ameba/chip_main.cmake b/examples/light-switch-app/ameba/chip_main.cmake
@@ -287,8 +287,7 @@ list(
     APPEND chip_main_cpp_flags
 
 	-Wno-unused-parameter
-	-std=gnu++11
-	-std=c++14
+	-std=c++17
 	-fno-rtti
 )
 target_compile_definitions(${chip_main} PRIVATE ${chip_main_flags} )
diff --git a/examples/lighting-app/ameba/chip_main.cmake b/examples/lighting-app/ameba/chip_main.cmake
@@ -274,8 +274,7 @@ list(
     APPEND chip_main_cpp_flags
 
 	-Wno-unused-parameter
-	-std=gnu++11
-	-std=c++14
+	-std=c++17
 	-fno-rtti
 )
 target_compile_definitions(${chip_main} PRIVATE ${chip_main_flags} )
diff --git a/examples/ota-provider-app/esp32/CMakeLists.txt b/examples/ota-provider-app/esp32/CMakeLists.txt
@@ -30,7 +30,7 @@ set(EXTRA_COMPONENT_DIRS
 )
 
 project(chip-ota-provider-app)
-idf_build_set_property(CXX_COMPILE_OPTIONS "-std=gnu++14;-Os;-DCHIP_HAVE_CONFIG_H" APPEND)
+idf_build_set_property(CXX_COMPILE_OPTIONS "-std=gnu++17;-Os;-DCHIP_HAVE_CONFIG_H" APPEND)
 idf_build_set_property(C_COMPILE_OPTIONS "-Os" APPEND)
 # For the C3, project_include.cmake sets -Wno-format, but does not clear various
 # flags that depend on -Wformat
diff --git a/examples/ota-requestor-app/ameba/chip_main.cmake b/examples/ota-requestor-app/ameba/chip_main.cmake
@@ -91,8 +91,7 @@ list(
     APPEND chip_main_cpp_flags
 
 	-Wno-unused-parameter
-	-std=gnu++11
-	-std=c++14
+	-std=c++17
 	-fno-rtti
 )
 target_compile_definitions(${chip_main} PRIVATE ${chip_main_flags} )
diff --git a/examples/persistent-storage/esp32/CMakeLists.txt b/examples/persistent-storage/esp32/CMakeLists.txt
@@ -28,7 +28,7 @@ set(EXTRA_COMPONENT_DIRS
 )
 
 project(chip-persistent-storage)
-idf_build_set_property(CXX_COMPILE_OPTIONS "-std=gnu++14;-Os;-DCHIP_HAVE_CONFIG_H" APPEND)
+idf_build_set_property(CXX_COMPILE_OPTIONS "-std=gnu++17;-Os;-DCHIP_HAVE_CONFIG_H" APPEND)
 idf_build_set_property(C_COMPILE_OPTIONS "-Os" APPEND)
 # For the C3, project_include.cmake sets -Wno-format, but does not clear various
 # flags that depend on -Wformat
diff --git a/examples/shell/esp32/CMakeLists.txt b/examples/shell/esp32/CMakeLists.txt
@@ -29,7 +29,7 @@ set(EXTRA_COMPONENT_DIRS
 )
 
 project(chip-shell)
-idf_build_set_property(CXX_COMPILE_OPTIONS "-std=gnu++14;-Os;-DCHIP_HAVE_CONFIG_H" APPEND)
+idf_build_set_property(CXX_COMPILE_OPTIONS "-std=gnu++17;-Os;-DCHIP_HAVE_CONFIG_H" APPEND)
 idf_build_set_property(C_COMPILE_OPTIONS "-Os" APPEND)
 
 # For the C3, project_include.cmake sets -Wno-format, but does not clear various
diff --git a/src/darwin/CHIPTool/CHIPTool.xcodeproj/project.pbxproj b/src/darwin/CHIPTool/CHIPTool.xcodeproj/project.pbxproj
@@ -447,7 +447,7 @@
 				ALWAYS_SEARCH_USER_PATHS = NO;
 				CLANG_ANALYZER_NONNULL = YES;
 				CLANG_ANALYZER_NUMBER_OBJECT_CONVERSION = YES_AGGRESSIVE;
-				CLANG_CXX_LANGUAGE_STANDARD = "gnu++14";
+				CLANG_CXX_LANGUAGE_STANDARD = "gnu++17";
 				CLANG_CXX_LIBRARY = "libc++";
 				CLANG_ENABLE_MODULES = YES;
 				CLANG_ENABLE_OBJC_ARC = YES;
@@ -508,7 +508,7 @@
 				ALWAYS_SEARCH_USER_PATHS = NO;
 				CLANG_ANALYZER_NONNULL = YES;
 				CLANG_ANALYZER_NUMBER_OBJECT_CONVERSION = YES_AGGRESSIVE;
-				CLANG_CXX_LANGUAGE_STANDARD = "gnu++14";
+				CLANG_CXX_LANGUAGE_STANDARD = "gnu++17";
 				CLANG_CXX_LIBRARY = "libc++";
 				CLANG_ENABLE_MODULES = YES;
 				CLANG_ENABLE_OBJC_ARC = YES;
diff --git a/src/darwin/Framework/Matter.xcodeproj/project.pbxproj b/src/darwin/Framework/Matter.xcodeproj/project.pbxproj
@@ -1686,7 +1686,7 @@
 			buildSettings = {
 				ALWAYS_SEARCH_USER_PATHS = NO;
 				CLANG_ANALYZER_NUMBER_OBJECT_CONVERSION = YES_AGGRESSIVE;
-				CLANG_CXX_LANGUAGE_STANDARD = "gnu++14";
+				CLANG_CXX_LANGUAGE_STANDARD = "gnu++17";
 				CLANG_CXX_LIBRARY = "libc++";
 				CLANG_ENABLE_MODULES = YES;
 				CLANG_ENABLE_OBJC_ARC = YES;
@@ -1858,7 +1858,7 @@
 			buildSettings = {
 				ALWAYS_SEARCH_USER_PATHS = NO;
 				CLANG_ANALYZER_NUMBER_OBJECT_CONVERSION = YES_AGGRESSIVE;
-				CLANG_CXX_LANGUAGE_STANDARD = "gnu++14";
+				CLANG_CXX_LANGUAGE_STANDARD = "gnu++17";
 				CLANG_CXX_LIBRARY = "libc++";
 				CLANG_ENABLE_MODULES = YES;
 				CLANG_ENABLE_OBJC_ARC = YES;
diff --git a/third_party/ti_simplelink_sdk/BUILD.gn b/third_party/ti_simplelink_sdk/BUILD.gn
@@ -110,7 +110,7 @@ config("ti_simplelink_freertos_config") {
 config("ti_simplelink_posix_config") {
   include_dirs = [ "${ti_simplelink_sdk_root}/source/ti/posix/gcc" ]
   cflags_c = [ "-std=c11" ]
-  cflags_cc = [ "-std=c++14" ]
+  cflags_cc = [ "-std=c++17" ]
   cflags = [
     "-Wno-maybe-uninitialized",
     "-Wno-sign-compare",
diff --git a/third_party/ti_simplelink_sdk/ti_simplelink_sdk.gni b/third_party/ti_simplelink_sdk/ti_simplelink_sdk.gni
@@ -277,7 +277,7 @@ template("ti_simplelink_sdk") {
   config("${sdk_target_name}_posix_config") {
     include_dirs = [ "${ti_simplelink_sdk_root}/source/ti/posix/gcc" ]
     cflags_c = [ "-std=c11" ]
-    cflags_cc = [ "-std=c++14" ]
+    cflags_cc = [ "-std=c++17" ]
     cflags = [
       "-Wno-maybe-uninitialized",
       "-Wno-sign-compare",

Original file line number	Diff line number	Diff line change
`@@ -298,8 +298,7 @@ list(`
`298`	`298`	`APPEND chip_main_cpp_flags`
`299`	`299`
`300`	`300`	`-Wno-unused-parameter`
`301`		`- -std=gnu++11`
`302`		`- -std=c++14`
	`301`	`+ -std=c++17`
`303`	`302`	`-fno-rtti`
`304`	`303`	`)`
`305`	`304`	`target_compile_definitions(${chip_main} PRIVATE ${chip_main_flags} )`
Original file line number	Diff line number	Diff line change
`@@ -258,8 +258,7 @@ list(`
`258`	`258`	`APPEND chip_main_cpp_flags`
`259`	`259`
`260`	`260`	`-Wno-unused-parameter`
`261`		`- -std=gnu++11`
`262`		`- -std=c++14`
	`261`	`+ -std=c++17`
`263`	`262`	`-fno-rtti`
`264`	`263`	`)`
`265`	`264`	`target_compile_definitions(${chip_main} PRIVATE ${chip_main_flags} )`
Original file line number	Diff line number	Diff line change
`@@ -114,8 +114,7 @@ list(`
`114`	`114`	`APPEND chip_main_cpp_flags`
`115`	`115`
`116`	`116`	`-Wno-unused-parameter`
`117`		`- -std=gnu++11`
`118`		`- -std=c++14`
	`117`	`+ -std=c++17`
`119`	`118`	`-fno-rtti`
`120`	`119`	`)`
`121`	`120`	`target_compile_definitions(${chip_main} PRIVATE ${chip_main_flags} )`
Original file line number	Diff line number	Diff line change
`@@ -287,8 +287,7 @@ list(`
`287`	`287`	`APPEND chip_main_cpp_flags`
`288`	`288`
`289`	`289`	`-Wno-unused-parameter`
`290`		`- -std=gnu++11`
`291`		`- -std=c++14`
	`290`	`+ -std=c++17`
`292`	`291`	`-fno-rtti`
`293`	`292`	`)`
`294`	`293`	`target_compile_definitions(${chip_main} PRIVATE ${chip_main_flags} )`
Original file line number	Diff line number	Diff line change
`@@ -274,8 +274,7 @@ list(`
`274`	`274`	`APPEND chip_main_cpp_flags`
`275`	`275`
`276`	`276`	`-Wno-unused-parameter`
`277`		`- -std=gnu++11`
`278`		`- -std=c++14`
	`277`	`+ -std=c++17`
`279`	`278`	`-fno-rtti`
`280`	`279`	`)`
`281`	`280`	`target_compile_definitions(${chip_main} PRIVATE ${chip_main_flags} )`
Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ set(EXTRA_COMPONENT_DIRS`
`30`	`30`	`)`
`31`	`31`
`32`	`32`	`project(chip-ota-provider-app)`
`33`		`-idf_build_set_property(CXX_COMPILE_OPTIONS "-std=gnu++14;-Os;-DCHIP_HAVE_CONFIG_H" APPEND)`
	`33`	`+idf_build_set_property(CXX_COMPILE_OPTIONS "-std=gnu++17;-Os;-DCHIP_HAVE_CONFIG_H" APPEND)`
`34`	`34`	`idf_build_set_property(C_COMPILE_OPTIONS "-Os" APPEND)`
`35`	`35`	`# For the C3, project_include.cmake sets -Wno-format, but does not clear various`
`36`	`36`	`# flags that depend on -Wformat`
Original file line number	Diff line number	Diff line change
`@@ -91,8 +91,7 @@ list(`
`91`	`91`	`APPEND chip_main_cpp_flags`
`92`	`92`
`93`	`93`	`-Wno-unused-parameter`
`94`		`- -std=gnu++11`
`95`		`- -std=c++14`
	`94`	`+ -std=c++17`
`96`	`95`	`-fno-rtti`
`97`	`96`	`)`
`98`	`97`	`target_compile_definitions(${chip_main} PRIVATE ${chip_main_flags} )`
Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ set(EXTRA_COMPONENT_DIRS`
`28`	`28`	`)`
`29`	`29`
`30`	`30`	`project(chip-persistent-storage)`
`31`		`-idf_build_set_property(CXX_COMPILE_OPTIONS "-std=gnu++14;-Os;-DCHIP_HAVE_CONFIG_H" APPEND)`
	`31`	`+idf_build_set_property(CXX_COMPILE_OPTIONS "-std=gnu++17;-Os;-DCHIP_HAVE_CONFIG_H" APPEND)`
`32`	`32`	`idf_build_set_property(C_COMPILE_OPTIONS "-Os" APPEND)`
`33`	`33`	`# For the C3, project_include.cmake sets -Wno-format, but does not clear various`
`34`	`34`	`# flags that depend on -Wformat`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ set(EXTRA_COMPONENT_DIRS`
`29`	`29`	`)`
`30`	`30`
`31`	`31`	`project(chip-shell)`
`32`		`-idf_build_set_property(CXX_COMPILE_OPTIONS "-std=gnu++14;-Os;-DCHIP_HAVE_CONFIG_H" APPEND)`
	`32`	`+idf_build_set_property(CXX_COMPILE_OPTIONS "-std=gnu++17;-Os;-DCHIP_HAVE_CONFIG_H" APPEND)`
`33`	`33`	`idf_build_set_property(C_COMPILE_OPTIONS "-Os" APPEND)`
`34`	`34`
`35`	`35`	`# For the C3, project_include.cmake sets -Wno-format, but does not clear various`