Skip to content

3.1 exclusiveMinimum and exclusiveMaximum are unsupported by external dependency #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
charjr opened this issue Nov 16, 2024 · 1 comment
Milestone

Comments

@charjr
Copy link
Collaborator

charjr commented Nov 16, 2024

Currently, neither cebe/php-openapi nor devizzent/cebe-php-openapi are capable of supporting numeric values for exclusiveMinimum nor exclusiveMaximum.

I've made a PR to try and fix this DEVizzent/cebe-php-openapi#23

Alternatives:

  • Remove dependency and parse openapi independently
  • Do not use external validation from these libraries, perhaps requiring a try-catch for type errors.

Obviously the former is cleaner, but the latter is quicker.

@charjr charjr added this to the OpenAPI 3.1 milestone Nov 16, 2024
@charjr charjr changed the title 3.1 exclusiveMinimum and exclusiveMaximum are unsupported by external library 3.1 exclusiveMinimum and exclusiveMaximum are unsupported by external dependency Nov 18, 2024
@charjr
Copy link
Collaborator Author

charjr commented Nov 20, 2024

The external dependency is now capable of supporting numeric exclusiveMinimum and exclusiveMaximum.

It still has a default of false though. So we cannot fully validate whether the user provided it correctly. So we will have to assume, for 3.1, that if exclusiveMinimum or exclusiveMaximum are set to false that they have been omitted.

@charjr charjr closed this as completed Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant