Skip to content

Commit 9b8f7c4

Browse files
AIFlowMLAIFlowML
authored
Fixed all the logic and type issues (elizaOS#2844)
1 parent 4712839 commit 9b8f7c4

File tree

9 files changed

+50
-43
lines changed

9 files changed

+50
-43
lines changed

‎packages/plugin-story/src/actions/attachTerms.ts

+7-6
Original file line numberDiff line numberDiff line change
@@ -81,20 +81,21 @@ export const attachTermsAction = {
8181
runtime: IAgentRuntime,
8282
message: Memory,
8383
state: State,
84-
options: any,
84+
_options: Record<string, unknown>,
8585
callback?: HandlerCallback
8686
): Promise<boolean> => {
8787
elizaLogger.log("Starting ATTACH_TERMS handler...");
8888

89-
// initialize or update state
90-
if (!state) {
91-
state = (await runtime.composeState(message)) as State;
89+
// Initialize or update state
90+
let currentState = state;
91+
if (!currentState) {
92+
currentState = (await runtime.composeState(message)) as State;
9293
} else {
93-
state = await runtime.updateRecentMessageState(state);
94+
currentState = await runtime.updateRecentMessageState(currentState);
9495
}
9596

9697
const attachTermsContext = composeContext({
97-
state,
98+
state: currentState,
9899
template: attachTermsTemplate,
99100
});
100101

‎packages/plugin-story/src/actions/getAvailableLicenses.ts

+9-7
Original file line numberDiff line numberDiff line change
@@ -89,8 +89,7 @@ const formatLicenseTerms = (license: IPLicenseDetails): string => {
8989
• Derivatives: ${terms.derivativesAllowed ? "Allowed" : "Not Allowed"}
9090
• Derivatives Attribution: ${terms.derivativesAttribution ? "Required" : "Not Required"}
9191
• Derivatives Approval: ${terms.derivativesApproval ? "Required" : "Not Required"}
92-
• Revenue Share: ${terms.commercialRevenueShare ? terms.commercialRevenueShare + "%" : "Not Required"}
93-
`;
92+
• Revenue Share: ${terms.commercialRevenueShare ? `${terms.commercialRevenueShare}%` : "Not Required"}`;
9493
};
9594

9695
/**
@@ -103,21 +102,24 @@ export const getAvailableLicensesAction = {
103102
runtime: IAgentRuntime,
104103
message: Memory,
105104
state: State,
106-
options: any,
105+
_options: Record<string, unknown>,
107106
callback?: HandlerCallback
108107
): Promise<boolean> => {
109108
elizaLogger.log("Starting GET_AVAILABLE_LICENSES handler...");
110109

111110
// Initialize or update state
112-
state = !state
113-
? ((await runtime.composeState(message)) as State)
114-
: await runtime.updateRecentMessageState(state);
111+
let currentState = state; // Create a new variable instead of reassigning parameter
112+
if (!currentState) {
113+
currentState = (await runtime.composeState(message)) as State;
114+
} else {
115+
currentState = await runtime.updateRecentMessageState(currentState);
116+
}
115117

116118
// Generate parameters from context
117119
const content = await generateObjectDeprecated({
118120
runtime,
119121
context: composeContext({
120-
state,
122+
state: currentState,
121123
template: getAvailableLicensesTemplate,
122124
}),
123125
modelClass: ModelClass.SMALL,

‎packages/plugin-story/src/actions/getIPDetails.ts

+8-5
Original file line numberDiff line numberDiff line change
@@ -70,20 +70,23 @@ export const getIPDetailsAction = {
7070
runtime: IAgentRuntime,
7171
message: Memory,
7272
state: State,
73-
options: any,
73+
_options: Record<string, unknown>,
7474
callback?: HandlerCallback
7575
): Promise<boolean> => {
7676
elizaLogger.log("Starting GET_IP_DETAILS handler...");
7777

7878
// Initialize or update state
79-
state = !state
80-
? ((await runtime.composeState(message)) as State)
81-
: await runtime.updateRecentMessageState(state);
79+
let currentState = state;
80+
if (!currentState) {
81+
currentState = (await runtime.composeState(message)) as State;
82+
} else {
83+
currentState = await runtime.updateRecentMessageState(currentState);
84+
}
8285

8386
// Generate content using template
8487
const content = await generateObjectDeprecated({
8588
runtime,
86-
context: composeContext({ state, template: getIPDetailsTemplate }),
89+
context: composeContext({ state: currentState, template: getIPDetailsTemplate }),
8790
modelClass: ModelClass.SMALL,
8891
});
8992

‎packages/plugin-story/src/actions/licenseIP.ts

+6-5
Original file line numberDiff line numberDiff line change
@@ -52,20 +52,21 @@ export const licenseIPAction = {
5252
runtime: IAgentRuntime,
5353
message: Memory,
5454
state: State,
55-
options: any,
55+
_options: Record<string, unknown>,
5656
callback?: HandlerCallback
5757
): Promise<boolean> => {
5858
elizaLogger.log("Starting LICENSE_IP handler...");
5959

6060
// initialize or update state
61-
if (!state) {
62-
state = (await runtime.composeState(message)) as State;
61+
let currentState = state;
62+
if (!currentState) {
63+
currentState = (await runtime.composeState(message)) as State;
6364
} else {
64-
state = await runtime.updateRecentMessageState(state);
65+
currentState = await runtime.updateRecentMessageState(currentState);
6566
}
6667

6768
const licenseIPContext = composeContext({
68-
state,
69+
state: currentState,
6970
template: licenseIPTemplate,
7071
});
7172

‎packages/plugin-story/src/actions/registerIP.ts

+7-6
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import {
1010
} from "@elizaos/core";
1111
import pinataSDK from "@pinata/sdk";
1212
import type { RegisterIpResponse } from "@story-protocol/core-sdk";
13-
import { createHash } from "crypto";
13+
import { createHash } from "node:crypto"; // Added node: protocol
1414
import { uploadJSONToIPFS } from "../functions/uploadJSONToIPFS";
1515
import { WalletProvider } from "../providers/wallet";
1616
import { registerIPTemplate } from "../templates";
@@ -79,20 +79,21 @@ export const registerIPAction = {
7979
runtime: IAgentRuntime,
8080
message: Memory,
8181
state: State,
82-
options: any,
82+
_options: Record<string, unknown>,
8383
callback?: HandlerCallback
8484
): Promise<boolean> => {
8585
elizaLogger.log("Starting REGISTER_IP handler...");
8686

8787
// initialize or update state
88-
if (!state) {
89-
state = (await runtime.composeState(message)) as State;
88+
let currentState = state;
89+
if (!currentState) {
90+
currentState = (await runtime.composeState(message)) as State;
9091
} else {
91-
state = await runtime.updateRecentMessageState(state);
92+
currentState = await runtime.updateRecentMessageState(currentState);
9293
}
9394

9495
const registerIPContext = composeContext({
95-
state,
96+
state: currentState,
9697
template: registerIPTemplate,
9798
});
9899

‎packages/plugin-story/src/functions/uploadJSONToIPFS.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import type PinataClient from "@pinata/sdk";
22

33
export async function uploadJSONToIPFS(
44
pinata: PinataClient,
5-
jsonMetadata: any
5+
jsonMetadata: Record<string, unknown> // Replaced any with Record<string, unknown>
66
): Promise<string> {
77
const { IpfsHash } = await pinata.pinJSONToIPFS(jsonMetadata);
88
return IpfsHash;

‎packages/plugin-story/src/lib/api.ts

+9-10
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ export async function getResource(
2020
resourceName: ResourceType,
2121
resourceId: string,
2222
// eslint-disable-next-line
23-
options?: QueryOptions
23+
_options?: QueryOptions
2424
) {
2525
try {
2626
elizaLogger.log(
@@ -37,16 +37,16 @@ export async function getResource(
3737
if (res.ok) {
3838
elizaLogger.log("Response is ok");
3939
return res.json();
40-
} else {
41-
elizaLogger.log("Response is not ok");
42-
elizaLogger.log(JSON.stringify(res));
43-
throw new Error(`HTTP error! status: ${res.status}`);
4440
}
41+
elizaLogger.log("Response is not ok");
42+
elizaLogger.log(JSON.stringify(res));
43+
throw new Error(`HTTP error! status: ${res.status}`);
4544
} catch (error) {
4645
console.error(error);
4746
}
4847
}
4948

49+
5050
export async function listResource(
5151
resourceName: ResourceType,
5252
options?: QueryOptions
@@ -80,11 +80,10 @@ export async function listResource(
8080
elizaLogger.log("Response is ok");
8181
elizaLogger.log(res.ok);
8282
return res.json();
83-
} else {
84-
elizaLogger.log("Response is not ok");
85-
elizaLogger.log(res);
86-
return res;
8783
}
84+
elizaLogger.log("Response is not ok");
85+
elizaLogger.log(res);
86+
return res;
8887
} catch (error) {
8988
elizaLogger.log("List resource Error");
9089
console.error(error);
@@ -119,7 +118,7 @@ export function convertLicenseTermObject(licenseTerms: Trait[]): LicenseTerms {
119118
? true
120119
: option.value === "false"
121120
? false
122-
: (option.value as any);
121+
: option.value as string | number; // Replaced any with string | number
123122
return acc as LicenseTerms;
124123
}, {});
125124
}

‎packages/plugin-story/src/providers/wallet.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -113,9 +113,9 @@ export const storyWalletProvider: Provider = {
113113
async get(
114114
runtime: IAgentRuntime,
115115
// eslint-disable-next-line
116-
message: Memory,
116+
_message: Memory,
117117
// eslint-disable-next-line
118-
state?: State
118+
_state?: State
119119
): Promise<string | null> {
120120
// Check if the user has a Story wallet
121121
if (!runtime.getSetting("STORY_PRIVATE_KEY")) {

‎packages/plugin-story/src/types/api.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -399,7 +399,7 @@ export interface IPMetadata {
399399
userAgent?: string;
400400
allow?: string;
401401
};
402-
[key: string]: any;
402+
[key: string]: unknown; // Replaced any with unknown
403403
}
404404

405405
export interface AssetMetadata {

0 commit comments

Comments
 (0)