Skip to content

Commit dabdb90

Browse files
committed
yolov8_node fixes
- typing added to enable_cb - fuse for v10 - ultralytics updated
1 parent d1177df commit dabdb90

File tree

2 files changed

+7
-9
lines changed

2 files changed

+7
-9
lines changed

requirements.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
opencv-python==4.8.1.78
22
typing-extensions>=4.4.0
3-
ultralytics==8.2.71
3+
ultralytics==8.2.79
44
super_gradients==3.7.1
55
lap==0.4.0

yolov8_ros/yolov8_ros/yolov8_node.py

+6-8
Original file line numberDiff line numberDiff line change
@@ -103,18 +103,11 @@ def on_configure(self, state: LifecycleState) -> TransitionCallbackReturn:
103103

104104
return TransitionCallbackReturn.SUCCESS
105105

106-
def enable_cb(self, request, response):
107-
self.enable = request.data
108-
response.success = True
109-
return response
110-
111106
def on_activate(self, state: LifecycleState) -> TransitionCallbackReturn:
112107
self.get_logger().info(f"Activating {self.get_name()}")
113108

114109
self.yolo = self.type_to_model[self.model_type](self.model)
115-
116-
if "v10" not in self.model:
117-
self.yolo.fuse()
110+
self.yolo.fuse()
118111

119112
# subs
120113
self._sub = self.create_subscription(
@@ -152,6 +145,11 @@ def on_cleanup(self, state: LifecycleState) -> TransitionCallbackReturn:
152145

153146
return TransitionCallbackReturn.SUCCESS
154147

148+
def enable_cb(self, request: SetBool.Request, response: SetBool.Response) -> SetBool.Response:
149+
self.enable = request.data
150+
response.success = True
151+
return response
152+
155153
def parse_hypothesis(self, results: Results) -> List[Dict]:
156154

157155
hypothesis_list = []

0 commit comments

Comments
 (0)