Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove id="modal-1-content" from example #257

Open
smth opened this issue Nov 9, 2019 · 0 comments
Open

Remove id="modal-1-content" from example #257

smth opened this issue Nov 9, 2019 · 0 comments
Labels
docs Related to documentation

Comments

@smth
Copy link

smth commented Nov 9, 2019

I found it a slight distraction to ponder the purpose of id="modal-1-content" in the markup example. I came to the conclusion that it is a legacy of when the example also included aria-describedby="modal-1-content". If this is the case, then for the sake of simplicity perhaps the modal-1-content ID should also be removed.

@dkniffin dkniffin added the docs Related to documentation label Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Related to documentation
Projects
None yet
Development

No branches or pull requests

2 participants