Modal window closes unexpectedly when 'mousedown' IN the modal and 'mouseup' on the background

[DimaGashko]

Here's a video: https://drive.google.com/file/d/150mGwQNYmXyfykiVVdkw1VhCKvBhfQ96/view

This is small but really annoying issue!

p.s. the easiest solution is replace 'click' event by 'mousedown' (probably)

[piotrpog]

+1 for this issue. Honestly, is there modal lib that gets that right?

Its really annoying if there is form in the modal, users often click form inputs and release mouse button outside modal which closes it!

[PeterDekkers]

Duplicate of #216

Worth mentioning that as a workaround you can disable clicking outside the modal to close by removing the data-micromodal-close attribute from the overlay.

I.e. change this:

<div class="modal__overlay" tabindex="-1" data-micromodal-close>

To this:

<div class="modal__overlay" tabindex="-1">

[PeterDekkers]

Also my 2 cents regarding the suggested fix of using the mousedown event. I guess this should only be done for the overlay. In all other situations—e.g. close button—the click event would be correct.

So possibly this means that the overlay should have a new data-micromodal-alternate-close attribute or some-such that listens to mousedown events.

Happy to make a PR if that's useful.

[DimaGashko]

@PeterDekkers yeah, removing data-micromodal-close is the solution sometimes, but I usually need that functionality too.

mousedown - probably, but it should be tested on mobile and other touch devices too

[PeterDekkers]

Yes indeed @DimaGashko, good point about touch devices.

[rmkane]

Any update on the status of this issue? Look like the close trigger is still shared among the close button and modal overlay.

[kalpeshsingh]

Hello folks!
I don't have bandwidth to work on this.

Please send PR if possible and @ghosh or I can merge it.

[dkniffin]

If anyone has time to make a PR for this, I'd be happy to review it. Otherwise, I'll get to it when I can.