You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Some advertising scripts pollute Array.prototype (e.g. Array.prototype.clear), which is iterated by micromodal in these two locations and ends up attempting to iterate over a function, leading to a TypeError.
Micromodal should use Object.keys(triggerMap).forEach() in these two locations to prevent this issue from happening.
The text was updated successfully, but these errors were encountered:
eligrey
changed the title
triggerMap iteration is broken when Array.prototype is polluted
triggerMap iteration is broken when Array.prototype is polluted
Sep 3, 2020
anujtenani
added a commit
to anujtenani/Micromodal
that referenced
this issue
Feb 28, 2021
#269 is not fixed. Please see this comment.
Some advertising scripts pollute
Array.prototype
(e.g.Array.prototype.clear
), which is iterated by micromodal in these two locations and ends up attempting to iterate over a function, leading to a TypeError.https://github.com/ghosh/Micromodal/blob/master/lib/src/index.js#L267
https://github.com/ghosh/Micromodal/blob/master/lib/src/index.js#L290
Micromodal should use
Object.keys(triggerMap).forEach()
in these two locations to prevent this issue from happening.The text was updated successfully, but these errors were encountered: