Skip to content

Commit 4345139

Browse files
authored
Merge pull request #1436 from microsoft/andrueastman/fixreleases
chore: use tagging from release please.
2 parents 1edca86 + 7f4c1cb commit 4345139

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

.github/workflows/build_test_validate.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ jobs:
4949

5050
publish-npm:
5151
if: "${{ github.event_name == 'push' && github.ref == 'refs/heads/main' && contains(github.event.head_commit.message, 'chore: release main') }}"
52-
needs: build
52+
needs: [build, check-typescript-version-matrix]
5353
environment:
5454
name: production_feed
5555
runs-on: ubuntu-latest
@@ -67,7 +67,7 @@ jobs:
6767
GITHUB_ACTOR: ${{ secrets.GIT_USERNAME }}
6868
- run: npm ci
6969
- run: npm run build
70-
- run: npx lerna publish from-package --yes
70+
- run: npx lerna publish from-package --no-push --yes
7171
env:
7272
NODE_AUTH_TOKEN: ${{secrets.npm_token}}
7373

release-please-config.json

-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
"separate-pull-requests": false,
88
"bump-minor-pre-major": true,
99
"bump-patch-for-minor-pre-major": true,
10-
"skip-github-release": true,
1110
"versioning": "prerelease",
1211
"packages": {
1312
"packages/abstractions": {

0 commit comments

Comments
 (0)