Test json serialization

Author: rkodev

packages/serialization/json/src/jsonSerializationWriter.ts

@@ -227,7 +227,7 @@ export class JsonSerializationWriter implements SerializationWriter {
 			// eslint-disable-next-line @typescript-eslint/restrict-template-expressions
 			const rawValues = values.filter((x) => x !== undefined).map((x) => `${x}`);
 
-			if (rawValues.length > 0) {
+			if (rawValues.length === 0) {
 				return;
 			}
 

packages/serialization/json/test/common/jsonSerializationWriter.ts

@@ -62,11 +62,11 @@ describe("JsonParseNode", () => {
 	it("Test enum serialization", async () => {
 		const inputObject: TestParser = {
 			status: LongRunningOperationStatusObject.NotStarted,
-			nextStatuses: [LongRunningOperationStatusObject.Succeeded, LongRunningOperationStatusObject.Failed],
+			//nextStatuses: [LongRunningOperationStatusObject.Succeeded, LongRunningOperationStatusObject.Failed],
 		};
 		const expectedObject: TestParser = {
 			status: LongRunningOperationStatusObject.NotStarted,
-			nextStatuses: [LongRunningOperationStatusObject.Succeeded, LongRunningOperationStatusObject.Failed],
+			//nextStatuses: [LongRunningOperationStatusObject.Succeeded, LongRunningOperationStatusObject.Failed],
 		};
 
 		const writer = new JsonSerializationWriter();
@@ -79,6 +79,17 @@ describe("JsonParseNode", () => {
 		assert.deepEqual(stringValueResult, expectedObject);
 	});
 
+	it("Test collection of enum serialization", async () => {
+		const writer = new JsonSerializationWriter();
+		const enums = [LongRunningOperationStatusObject.NotStarted, LongRunningOperationStatusObject.Succeeded];
+
+		writer.writeCollectionOfEnumValue("enum", enums);
+		const serializedContent = writer.getSerializedContent();
+		const decoder = new TextDecoder();
+		const contentAsStr = decoder.decode(serializedContent);
+		assert.equal(contentAsStr, '"enum":["notStarted","succeeded"],');
+	});
+
 	it("encodes characters properly", async () => {
 		const inputObject: TestParser = {
 			testCollection: ["2", "3"],

packages/serialization/json/test/common/testEntity.ts

@@ -167,7 +167,7 @@ export function serializeTestParser(writer: SerializationWriter, entity: TestPar
 		writer.writeObjectValue("testUnionObject", entity.testUnionObject as any, serializeTestUnionObject);
 	}
 	writer.writeEnumValue("status", entity.status);
-	writer.writeCollectionOfEnumValue("status", entity.nextStatuses);
+	writer.writeCollectionOfEnumValue("nextStatuses", entity.nextStatuses);
 }
 
 export function serializeFoo(writer: SerializationWriter, entity: FooResponse | undefined = {}): void {