Skip to content

Commit 948b249

Browse files
committed
Fix constructor
1 parent 60407b7 commit 948b249

File tree

2 files changed

+16
-8
lines changed

2 files changed

+16
-8
lines changed

packages/abstractions/src/serialization/parseNodeFactoryRegistry.ts

+7-3
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,15 @@ import { Parsable } from "./parsable";
1010
import type { ParsableFactory } from "./parsableFactory";
1111
import { BackingStoreParseNodeFactory } from "../store";
1212

13-
const jsonContentType = "application/json";
1413
/**
1514
* This factory holds a list of all the registered factories for the various types of nodes.
1615
*/
1716
export class ParseNodeFactoryRegistry implements ParseNodeFactory {
17+
/**
18+
* The content type for JSON data.
19+
*/
20+
private readonly jsonContentType = "application/json";
21+
1822
public getValidContentType(): string {
1923
throw new Error("The registry supports multiple content types. Get the registered factory instead.");
2024
}
@@ -84,7 +88,7 @@ export class ParseNodeFactoryRegistry implements ParseNodeFactory {
8488
* @returns the deserialized parsable object
8589
*/
8690
public deserializeFromJson<T extends Parsable>(bufferOrString: ArrayBuffer | string, factory: ParsableFactory<T>): Parsable {
87-
return this.deserialize(jsonContentType, bufferOrString, factory);
91+
return this.deserialize(this.jsonContentType, bufferOrString, factory);
8892
}
8993

9094
/**
@@ -94,7 +98,7 @@ export class ParseNodeFactoryRegistry implements ParseNodeFactory {
9498
* @returns the deserialized collection of parsable objects
9599
*/
96100
public deserializeCollectionFromJson<T extends Parsable>(bufferOrString: ArrayBuffer | string, factory: ParsableFactory<T>): T[] | undefined {
97-
return this.deserializeCollection(jsonContentType, bufferOrString, factory);
101+
return this.deserializeCollection(this.jsonContentType, bufferOrString, factory);
98102
}
99103

100104
/**

packages/abstractions/src/serialization/serializationWriterFactoryRegistry.ts

+9-5
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,13 @@ import type { Parsable } from "./parsable";
1010
import type { ModelSerializerFunction } from "./serializationFunctionTypes";
1111
import { BackingStoreSerializationWriterProxyFactory } from "../store";
1212

13-
const jsonContentType = "application/json";
1413
/** This factory holds a list of all the registered factories for the various types of nodes. */
1514
export class SerializationWriterFactoryRegistry implements SerializationWriterFactory {
15+
/**
16+
* The content type for JSON data.
17+
*/
18+
private readonly jsonContentType = "application/json";
19+
1620
public getValidContentType(): string {
1721
throw new Error("The registry supports multiple content types. Get the registered factory instead.");
1822
}
@@ -63,7 +67,7 @@ export class SerializationWriterFactoryRegistry implements SerializationWriterFa
6367
* @returns a buffer containing the serialized value
6468
*/
6569
public serializeToJson<T extends Parsable>(value: T, serializationFunction: ModelSerializerFunction<T>): ArrayBuffer {
66-
return this.serialize(jsonContentType, value, serializationFunction);
70+
return this.serialize(this.jsonContentType, value, serializationFunction);
6771
}
6872

6973
/**
@@ -73,7 +77,7 @@ export class SerializationWriterFactoryRegistry implements SerializationWriterFa
7377
* @returns a string representing the serialized value
7478
*/
7579
public serializeToJsonAsString<T extends Parsable>(value: T, serializationFunction: ModelSerializerFunction<T>): string {
76-
return this.serializeToString(jsonContentType, value, serializationFunction);
80+
return this.serializeToString(this.jsonContentType, value, serializationFunction);
7781
}
7882

7983
/**
@@ -83,7 +87,7 @@ export class SerializationWriterFactoryRegistry implements SerializationWriterFa
8387
* @returns a string representing the serialized value
8488
*/
8589
public serializeCollectionToJson<T extends Parsable>(values: T[], serializationFunction: ModelSerializerFunction<T>): ArrayBuffer {
86-
return this.serializeCollection(jsonContentType, values, serializationFunction);
90+
return this.serializeCollection(this.jsonContentType, values, serializationFunction);
8791
}
8892

8993
/**
@@ -93,7 +97,7 @@ export class SerializationWriterFactoryRegistry implements SerializationWriterFa
9397
* @returns a string representing the serialized value
9498
*/
9599
public serializeCollectionToJsonAsString<T extends Parsable>(values: T[], serializationFunction: ModelSerializerFunction<T>): string {
96-
return this.serializeCollectionToString(jsonContentType, values, serializationFunction);
100+
return this.serializeCollectionToString(this.jsonContentType, values, serializationFunction);
97101
}
98102

99103
/**

0 commit comments

Comments
 (0)