Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit e07f332

Browse files
committedFeb 13, 2024
Revert "fix malformed body and include additional optional data"
This reverts commit 26d18e1.
1 parent 26d18e1 commit e07f332

File tree

3 files changed

+5
-15
lines changed

3 files changed

+5
-15
lines changed
 

‎packages/abstractions/src/multipartBody.ts

+2-10
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ export class MultipartBody implements Parsable {
3131
partName: string,
3232
partContentType: string,
3333
content: T,
34-
additionalKV: {[key: string]: string} | undefined,
3534
serializationCallback?: ModelSerializerFunction<Parsable>,
3635
): void {
3736
if (!partName) throw new Error("partName cannot be undefined");
@@ -44,7 +43,6 @@ export class MultipartBody implements Parsable {
4443
contentType: partContentType,
4544
content,
4645
originalName: partName,
47-
additionalKV: additionalKV,
4846
serializationCallback,
4947
};
5048
}
@@ -96,7 +94,6 @@ interface MultipartEntry {
9694
contentType: string;
9795
content: any;
9896
originalName: string;
99-
additionalKV: {[key: string]: string} | undefined;
10097
serializationCallback?: ModelSerializerFunction<Parsable>;
10198
}
10299

@@ -131,18 +128,13 @@ export function serializeMultipartBody(
131128
writer.writeStringValue(undefined, "--" + boundary);
132129
const part = parts[partName];
133130
writer.writeStringValue("Content-Type", part.contentType);
134-
let dispositionValue = 'form-data; name="' + part.originalName + '"';
135-
if(part.additionalKV && Object.keys(part.additionalKV).length) {
136-
const additionalString = Object.entries(part.additionalKV).map(([k, v]) => `${k}="${v}"`).join("; ");
137-
dispositionValue += "; " + additionalString;
138-
}
139131
writer.writeStringValue(
140132
"Content-Disposition",
141-
dispositionValue,
133+
'form-data; name="' + part.originalName + '"',
142134
);
143135
writer.writeStringValue(undefined, "");
144136
if (typeof part.content === "string") {
145-
writer.writeStringValue(undefined, part.content, false);
137+
writer.writeStringValue(undefined, part.content);
146138
} else if (part.content instanceof ArrayBuffer) {
147139
writer.writeByteArrayValue(undefined, new Uint8Array(part.content));
148140
} else if (part.content instanceof Uint8Array) {

‎packages/abstractions/src/serialization/serializationWriter.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ export interface SerializationWriter {
1919
* @param key the key to write the value with.
2020
* @param value the value to write to the stream.
2121
*/
22-
writeStringValue(key?: string | undefined, value?: string | undefined, newline?: boolean): void;
22+
writeStringValue(key?: string | undefined, value?: string | undefined): void;
2323
/**
2424
* Writes the specified boolean value to the stream with an optional given key.
2525
* @param key the key to write the value with.

‎packages/serialization/multipart/src/multipartSerializationWriter.ts

+2-4
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ export class MultipartSerializationWriter implements SerializationWriter {
3232
public onStartObjectSerialization:
3333
| ((value: Parsable, writer: SerializationWriter) => void)
3434
| undefined;
35-
public writeStringValue = (key?: string, value?: string, newline: boolean = true): void => {
35+
public writeStringValue = (key?: string, value?: string): void => {
3636
if (key) {
3737
this.writeRawStringValue(key);
3838
}
@@ -42,9 +42,7 @@ export class MultipartSerializationWriter implements SerializationWriter {
4242
}
4343
this.writeRawStringValue(value);
4444
}
45-
if(newline) {
46-
this.writeRawStringValue("\r\n");
47-
}
45+
this.writeRawStringValue("\r\n");
4846
};
4947
private writeRawStringValue = (value?: string): void => {
5048
if (value) {

0 commit comments

Comments
 (0)
Please sign in to comment.