Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python2 port is missing git information and uses the wrong platform toolset #6005

Open
jbayardo opened this issue Apr 8, 2019 · 1 comment
Assignees
Labels
category:port-bug The issue is with a library, which is something the port should already support

Comments

@jbayardo
Copy link
Member

jbayardo commented Apr 8, 2019

When installing the python2 port, a few calls to git are made within the build:

git name-rev --name-only HEAD
git rev-parse --short HEAD
git describe --all --always --dirty

Since the port is downloaded as a zip file without additional git information (concretely, the .git directory), git will start traversing directories up in the tree looking for .git. In an environment with restricted access, this will hit vcpkg's .git and attempt to write the index.lock, leading to a restricted write.

It also attempts to build using PLATFORM_TOOLSET set to the default of VCPKG_PLATFORM_TOOLSET, which could be v141. The officially supported value is v140.

@PhoebeHui PhoebeHui self-assigned this Feb 20, 2020
@PhoebeHui PhoebeHui added category:question This issue is a question category:port-bug The issue is with a library, which is something the port should already support labels Mar 10, 2021
@PhoebeHui
Copy link
Contributor

VCPKG determines the setting of VCPKG_PLATFORM_TOOLSET from the environment see vcpkg_platform_toolset

I will take a look at the git issue.

@PhoebeHui PhoebeHui removed the category:question This issue is a question label Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Development

No branches or pull requests

2 participants