feat: suffix rather than prefix setter/getters

Fixes microsoft/vscode#108036

Author: connor4312

src/adapter/variables.ts

@@ -430,10 +430,9 @@ export class VariableStore {
     // Wrap up
     const resolved = flatten(await Promise.all(properties));
     resolved.sort((a, b) => {
-      const aname = a.v.name.includes(' ') ? a.v.name.split(' ')[1] : a.v.name;
-      const bname = b.v.name.includes(' ') ? b.v.name.split(' ')[1] : b.v.name;
+      const aname = a.v.name.includes(' ') ? a.v.name.split(' ')[0] : a.v.name;
+      const bname = b.v.name.includes(' ') ? b.v.name.split(' ')[0] : b.v.name;
       if (!isNaN(+aname) && !isNaN(+bname)) return +aname - +bname;
-      // tslint:disable-next-line
       const delta = b.weight - a.weight;
       return delta ? delta : aname.localeCompare(bname);
     });
@@ -521,14 +520,14 @@ export class VariableStore {
       } else {
         const obj = owner.wrap(p.name, p.get);
         obj.evaluteOnInspect = true;
-        result.push(this._createGetter(`get ${p.name}`, obj, 'propertyValue'));
+        result.push(this._createGetter(`${p.name} (get)`, obj, 'propertyValue'));
       }
     }
 
     // add setter if present
     if (p.set && p.set.type !== 'undefined') {
       result.push(
-        await this._createVariable(`set ${p.name}`, owner.wrap(p.name, p.set), 'propertyValue'),
+        await this._createVariable(`${p.name} (set)`, owner.wrap(p.name, p.set), 'propertyValue'),
       );
     }
 

src/test/evaluate/evaluate-auto-expands-getter-447.txt

@@ -1,16 +1,16 @@
 > result: {}
-    > set foo: ƒ foo(x) {}
-        > get arguments: ƒ ()
-        > set arguments: ƒ ()
-        > get caller: ƒ ()
-        > set caller: ƒ ()
+    > foo (set): ƒ foo(x) {}
+        > arguments (get): ƒ ()
+        > arguments (set): ƒ ()
+        > caller (get): ƒ ()
+        > caller (set): ƒ ()
         length: 1
         name: 'set foo'
         [[FunctionLocation]]: @ <eval>/VM<xx>:1
         > [[Scopes]]: Scopes[1]
         > __proto__: function () { [native code] }
     > __proto__: Object
-        > set foo: ƒ foo(x) {}
+        > foo (set): ƒ foo(x) {}
         > __proto__: Object
 
 > result: {}
@@ -20,18 +20,18 @@
         > __proto__: Object
 
 > result: {}
-    > get foo: ƒ foo() { throw 'wat'; }
-        > get arguments: ƒ ()
-        > set arguments: ƒ ()
-        > get caller: ƒ ()
-        > set caller: ƒ ()
+    > foo (get): ƒ foo() { throw 'wat'; }
+        > arguments (get): ƒ ()
+        > arguments (set): ƒ ()
+        > caller (get): ƒ ()
+        > caller (set): ƒ ()
         length: 0
         name: 'get foo'
         [[FunctionLocation]]: @ <eval>/VM<xx>:1
         > [[Scopes]]: Scopes[1]
         > __proto__: function () { [native code] }
     > __proto__: Object
-        > get foo: ƒ foo() { throw 'wat'; }
+        > foo (get): ƒ foo() { throw 'wat'; }
         > __proto__: Object
 
 > result: {}

src/test/evaluate/evaluate-default.txt

@@ -18,17 +18,17 @@ result: 3
     0: 1
     1: 2
     2: 3
-    > get buffer: ƒ buffer()
-    > get byteLength: ƒ byteLength()
-    > get byteOffset: ƒ byteOffset()
-    > get length: ƒ length()
-    > get Symbol(Symbol.toStringTag): ƒ [Symbol.toStringTag]()
+    > buffer (get): ƒ buffer()
+    > byteLength (get): ƒ byteLength()
+    > byteOffset (get): ƒ byteOffset()
+    > length (get): ƒ length()
+    > Symbol(Symbol.toStringTag) (get): ƒ [Symbol.toStringTag]()
     > __proto__: TypedArray
 
 > result: ArrayBuffer(3)
     > [[Int8Array]]: Int8Array(3) [1, 2, 3]
     > [[Uint8Array]]: Uint8Array(3) [1, 2, 3]
-    > get byteLength: ƒ byteLength()
+    > byteLength (get): ƒ byteLength()
     > __proto__: ArrayBuffer
 
 > result: Proxy {a: 1}
@@ -37,53 +37,53 @@ result: 3
     > [[Target]]: Object
 
 > result: {}
-    > set foo: ƒ foo(x) {}
-        > get arguments: ƒ ()
-        > set arguments: ƒ ()
-        > get caller: ƒ ()
-        > set caller: ƒ ()
+    > foo (set): ƒ foo(x) {}
+        > arguments (get): ƒ ()
+        > arguments (set): ƒ ()
+        > caller (get): ƒ ()
+        > caller (set): ƒ ()
         length: 1
         name: 'set foo'
         [[FunctionLocation]]: @ <eval>/VM<xx>:1
         > [[Scopes]]: Scopes[1]
         > __proto__: function () { [native code] }
     > __proto__: Object
-        > set foo: ƒ foo(x) {}
+        > foo (set): ƒ foo(x) {}
         > __proto__: Object
 
 > result: {}
-    > get foo: ƒ foo() { return 42 }
+    > foo (get): ƒ foo() { return 42 }
         42
     > __proto__: Object
-        > get foo: ƒ foo() { return 42 }
+        > foo (get): ƒ foo() { return 42 }
         > __proto__: Object
 
 > result: {}
-    > get foo: ƒ foo() { throw 'wat'; }
-        > get arguments: ƒ ()
-        > set arguments: ƒ ()
-        > get caller: ƒ ()
-        > set caller: ƒ ()
+    > foo (get): ƒ foo() { throw 'wat'; }
+        > arguments (get): ƒ ()
+        > arguments (set): ƒ ()
+        > caller (get): ƒ ()
+        > caller (set): ƒ ()
         length: 0
         name: 'get foo'
         [[FunctionLocation]]: @ <eval>/VM<xx>:1
         > [[Scopes]]: Scopes[1]
         > __proto__: function () { [native code] }
     > __proto__: Object
-        > get foo: ƒ foo() { throw 'wat'; }
+        > foo (get): ƒ foo() { throw 'wat'; }
         > __proto__: Object
 
 Evaluating#1: setTimeout(() => { throw new Error('bar')}, 0)
 stderr> Uncaught Error: bar
 stderr> > Uncaught Error: bar
-stderr>     
+stderr>
 <anonymous> @ localhost꞉8001/eval1.js:1:26
 ◀ setTimeout ▶
 <anonymous> @ localhost꞉8001/eval1.js:1
 
 stderr> Uncaught Error: baz
 stderr> > Uncaught Error: baz
-stderr>     
+stderr>
 <anonymous> @ <eval>/VM<xx>:1:26
 ◀ setTimeout ▶
 <anonymous> @ <eval>/VM<xx>:1
@@ -94,7 +94,7 @@ stderr>
 
 stderr> Uncaught Error: error2
 stderr> > Uncaught Error: error2
-stderr>     
+stderr>
 throwError @ ${workspaceFolder}/web/browserify/module1.ts:6:9
 <anonymous> @ <eval>/VM<xx>:1:27
 ◀ setTimeout ▶

src/test/evaluate/evaluate-repl.txt

@@ -17,7 +17,7 @@ result: 1234567890n
 <error>: Uncaught ReferenceError: baz is not defined
 
 > result: Map(1) {hello => ƒ ()}
-    > get size: ƒ size()
+    > size (get): ƒ size()
     > [[Entries]]: Array(1)
     > __proto__: Map
 

src/test/variables/variables-object-customdescriptiongenerator-using-function-declaration.txt

@@ -1,3 +1,3 @@
 > result: using function: Instance of bar
-    > get getter: ƒ getter() {}
+    > getter (get): ƒ getter() {}
     > __proto__: using function: Instance of bar

src/test/variables/variables-object-customdescriptiongenerator-using-statement-syntax.txt

@@ -1,3 +1,3 @@
 > result: using statement: Instance of bar
-    > get getter: ƒ getter() {}
+    > getter (get): ƒ getter() {}
     > __proto__: using statement: Instance of bar

src/test/variables/variables-object-customdescriptiongenerator-using-statement-with-return-syntax.txt

@@ -1,3 +1,3 @@
 > result: using statement return: Instance of bar
-    > get getter: ƒ getter() {}
+    > getter (get): ƒ getter() {}
     > __proto__: using statement return: Instance of bar

src/test/variables/variables-object-deep-accessor.txt

@@ -1,3 +1,3 @@
 > result: Bar
-    > get getter: ƒ getter() {}
+    > getter (get): ƒ getter() {}
     > __proto__: Foo

src/test/variables/variables-object-get-set.txt

@@ -1,6 +1,6 @@
 > result: {getter: <accessor>, accessor: <accessor>}
-    > get accessor: () => {}
-    > set accessor: () => {}
-    > get getter: () => {}
-    > set setter: () => {}
+    > accessor (get): () => {}
+    > accessor (set): () => {}
+    > getter (get): () => {}
+    > setter (set): () => {}
     > __proto__: Object

src/test/variables/variables-web-tags.txt

@@ -2,5 +2,5 @@
     > 0: meta
     > 1: title
     > foo: meta
-    > get length: ƒ length()
+    > length (get): ƒ length()
     > __proto__: HTMLCollection