Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support abandonment of recent folders with unsaved changes #238594

Closed
Clockwork-Muse opened this issue Jan 23, 2025 · 8 comments
Closed

Support abandonment of recent folders with unsaved changes #238594

Clockwork-Muse opened this issue Jan 23, 2025 · 8 comments
Labels
feature-request Request for new features or functionality workbench-hot-exit Preservation of unsaved changes across restarts

Comments

@Clockwork-Muse
Copy link

I'm trying to clean up my list of recent folders. And yet, if I had any unsaved changes (including from any temporary "notebook" windows), I get:

Image

The original source is gone. I no longer want whatever files they may have been. Many of these were devcontainers, that have been removed from docker via docker system prune -af --volumes - I'd have to re-clone the repo and rebuild the container to even look at them (however long that takes). Or in other situations the target system may simply be permanently gone for whatever reason (ie, were attached to a remote device that got sent back to a factory).

Can we please get some sort of Abandon button here, to account for that?

@amunger
Copy link
Collaborator

amunger commented Jan 23, 2025

when are you getting that pop-up? Do you have repro steps for this?

@amunger amunger added the info-needed Issue requires more information from poster label Jan 23, 2025
@Clockwork-Muse
Copy link
Author

I'm getting the pop-up when I try to "clean up" my recently closed:

  • File -> Open Recent -> More...
  • Mouse over the far-right of the line on the dialog box, and an X will appear. Click that X:

Image

Folders with unsaved files will initially have a filled circle in place of the X.

Unfortunately, I don't have a repro to set the situation up at the moment. My guess is that something around the timing of losing connection to the location (devcontainer or remote host) while having unsaved changes means that closing the window doesn't pop up the normal "discard changes" dialog.

@amunger amunger assigned bpasero and unassigned amunger Jan 24, 2025
@amunger amunger removed info-needed Issue requires more information from poster triage-needed labels Jan 24, 2025
@bpasero
Copy link
Member

bpasero commented Jan 24, 2025

Backups are persisted locally, even for remote workspaces so you should be able to get rid of them by manually deleting the contents in the %APPDATA%\Code\Backups folder, can you check the contents? Make sure to not delete it all if you have any other dirty files you want to preserve though.

@bpasero bpasero added the info-needed Issue requires more information from poster label Jan 24, 2025
@Clockwork-Muse
Copy link
Author

Yes, I have contents in %APPDATA$\Code\Backups. Very mysteriously named hash filenames.
Obviously, I can delete these files, but:

  1. This isn't a discoverable solution, because I didn't know this was a relevant folder, or even that it existed.
  2. It's also not a friendly solution, because there isn't a way to tell what folder this refers to.

@bpasero bpasero added feature-request Request for new features or functionality workbench-hot-exit Preservation of unsaved changes across restarts and removed info-needed Issue requires more information from poster labels Jan 25, 2025
@bpasero bpasero removed their assignment Jan 25, 2025
@vs-code-engineering vs-code-engineering bot added this to the Backlog Candidates milestone Jan 25, 2025
Copy link

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@1040170566
Copy link

1040170566 commented Feb 27, 2025

I've encountered this issue as well. I have absolutely no idea which file is supposedly unsaved, but the notification persists, causing this workspace to remain on the list. I could choose to ignore it, but it's quite bothersome.

Image

Image

Copy link

This feature request has not yet received the 20 community upvotes it takes to make to our backlog. 10 days to go. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

Copy link

🙁 In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@vs-code-engineering vs-code-engineering bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality workbench-hot-exit Preservation of unsaved changes across restarts
Projects
None yet
Development

No branches or pull requests

4 participants