Type of suggestion not indicated to screen reader users

[meganrogge]

When using ctrl+space, to get suggestions, sighted users have an icon which tells them the type of suggestion that is currently focused - a symbol, function, method, etc. We should indicate this information to screen reader users.

I am thinking we should add this information to the end of the aria label, but also don't want it to be too verbose.

cc @jooyoungseo, @rperez030 for feedback

[rperez030]

I think this could follow the same convention as the "Go to Symbol in Editor" command.

[meganrogge]

For me, on macOS with VoiceOver, I do not hear any symbol icon info when using Go To Symbol in Editor. @rperez030 what do you hear?

[rperez030]

For me, on macOS with VoiceOver, I do not hear any symbol icon info when using Go To Symbol in Editor. @rperez030 what do you hear?

You are right. It sounds like we have another issue to investigate. on Windows i hear something like: "encode_image (function) 2 of 10", but Voiceover only reads the symbol. another place where we use the same convention is the outline view inside Explorer (Explorer: Focus on Outline view command). This one work well in both platforms.

[meganrogge]

To verify:

• start a screen reader
• in the editor and terminal separately, invoke suggestions
• verify that you hear the type of suggestion at the end of the aria label

[roblourens]

I don't think I hear the suggestion type anywhere, what would that be like? Tried some different types in editor and terminal

[meganrogge]

I can reproduce 🤔 . I see that the aria label is correctly set in both places

[meganrogge]

I also see it gets applied here

[meganrogge]

I think that role of option is the issue here - when that's the case, screen readers pay attention to the text of the option instead of the aria label.

[meganrogge]

listitem works

[meganrogge]

@rperez030 it would be great if you could pls test this fix in insider's tomorrow. Use ctrl+space in the editor to try it out.

[meganrogge]

This was tested by Roberto