Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build failed - unit test failure #239642

Closed
amunger opened this issue Feb 4, 2025 · 4 comments
Closed

Build failed - unit test failure #239642

amunger opened this issue Feb 4, 2025 · 4 comments
Assignees
Milestone

Comments

@amunger
Copy link
Contributor

amunger commented Feb 4, 2025

Build: https://dev.azure.com/monacotools/a6d41577-0fa3-498e-af22-257312ff0545/_build/results?buildId=317618
Changes: a58d48f...30dbfbb

The RandomInt, "should include min and max" unit test failed, which, if it were truly random and I if understand probability well enough, has a 1 in 20 trillion chance of happening (0.8 ^ 100).

randomInt positive numbers max: 5, min: 0 should include min and max (reason: Expected 2,1,1,3,2,2,1,4,4,5,4,2,4,5,3,2,3,2,3,1,5,1,2,4,3,1,4,3,3,2,1,1,1,4,2,3,5,4,3,2,1,1,1,1,2,3,1,1,3,3,2,3,3,5,1,3,3,2,4,2,2,2,4,4,1,4,1,1,5,4,5,3,3,2,3,4,3,1,3,2,2,4,2,4,2,2,3,5,3,2,4,3,4,1,1,2,5,2,5,4 to include 0.
@bpasero bpasero added this to the February 2025 milestone Feb 5, 2025
@aeschli aeschli added the postponed-during-endgame Endgame champ removed the planed milestone label Feb 28, 2025
@aeschli aeschli modified the milestones: February 2025, Backlog Feb 28, 2025
@bpasero bpasero modified the milestones: Backlog, March 2025 Feb 28, 2025
@bpasero
Copy link
Member

bpasero commented Feb 28, 2025

@aeschli I do not think test failures should move to backlog

@bpasero bpasero removed the postponed-during-endgame Endgame champ removed the planed milestone label Feb 28, 2025
@legomushroom
Copy link
Member

Sorry I've missed this, hope it did not bother you a lot meanwhile 😞
Of course it is pseudo-random, and probably CI did not have enough entropy collected yet for the job. Let me try to make it more reliable 🏃

@legomushroom
Copy link
Member

Complete by #244763

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants