Markdown support: issue with dragging folder into editor to create a link on Linux edition of VSCode

[hurrellit]

Does this issue occur when all extensions are disabled?: Yes

• VS Code Version: 1.97.2 (latest)
• OS Version: Ubuntu/Windows 10

Steps to Reproduce:

1. Open an .md file
2. Drag a folder from the left hand File Explorer and drop it into the editor while holding the SHIFT key down
3. Using the Microsoft Windows version of VSCode this action will result in the creation of a markdown style relative link in the editor as expected, e.g.:

[text](../../../folder_name)

4. Using the .deb file installed release of VSCode on Ubuntu Desktop or Linux Mint desktop, the same action results in the absolute path to the folder being pasted into the editor, e.g.:

/home/my_user/Documents/gitlab/doc/content/en/some/path/folder_name

I feel that the behaviour in the Linux distros is incorrect and is a bug and a markdown style link should be created instead.

I do not have any extensions installed in VSCode and all settings are in their default state (I have not changed any).

Note that I can drag an .md file or an image type file (.png, .jpg etc.) from a folder in the left hand explorer and drop it into the editor and on both Linux and Windows a markdown link will be created as expected with the relative path to the file - so I know the drag and drop facility is working as designed.

[mjbvz]

I suspect this is related to either electron or the OS not creating a proper text/uri-list entry for the drag event. The other cases work because the drag even should have file objects, but that isn't the case for a folder

Marking as help wanted if someone wants to take a look:

vscode/src/vs/editor/contrib/dropOrPasteInto/browser/dropIntoEditorController.ts

Line 94 in d40c580

if (!dragEvent.dataTransfer || !editor.hasModel()) {

[mkhuzaima]

I have spent some time understanding this issue and believe I can resolve it. @mjbvz , could you please assign it to me?

[mkhuzaima]

@mjbvz Basically, there are 2 problems (one about absolute path), and one about link should be in markdown format.

It is because text/uri-list is not set for directory. Works fine, if we remove the condition, so that, it works for both files and directories.

vscode/src/vs/workbench/browser/dnd.ts

Lines 271 to 278 in 3e74979

	} else if (!resourceOrEditor.isDirectory) {
	editor = {
	resource: resourceOrEditor.resource,
	options: {
	selection: resourceOrEditor.selection,
	}
	};
	}

[mkhuzaima]

I have created a pull request that solves the issue. Let me now if any changes are required to the approach.