Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure we have just pushEdits when handling edits #242854

Closed
DonJayamanne opened this issue Mar 7, 2025 · 1 comment · Fixed by #245183
Closed

Ensure we have just pushEdits when handling edits #242854

DonJayamanne opened this issue Mar 7, 2025 · 1 comment · Fixed by #245183
Assignees
@DonJayamanne @connor4312
Labels
chat debt Code quality issues insiders-released Patch has been released in VS Code Insiders
Milestone
April 2025

Comments

@DonJayamanne
Copy link
Contributor

DonJayamanne commented Mar 7, 2025 •
edited
Loading

Collapse all of pushText/pushNotebookCellText/pushNotebook into just pushEdit
See comments here #241350 (comment)
@DonJayamanne DonJayamanne added chat debt Code quality issues labels Mar 7, 2025
@DonJayamanne DonJayamanne changed the title Ensure we have just pushEdits instead of pushText/pushNotebookCellText/pushNotebook Ensure we have just pushEdits when handling edits Mar 7, 2025
@DonJayamanne
Copy link
Contributor Author

Need to wait until inlineChat & Edits use the same code paths, to ensure we get the same set of messages.
Today we have code that tries to be backwards compatible,
Easier to not have to deal with backwards compatibility knowing the messages arriving will always be a specific shape.

connor4312 added a commit that referenced this issue Mar 31, 2025
@connor4312
chat: ensure we have just pushEdits when handling edits
b69ba7f 
Fixes #242854
@connor4312 connor4312 mentioned this issue Mar 31, 2025
Merged
connor4312 added a commit that referenced this issue Mar 31, 2025
@connor4312
chat: ensure we have just pushEdits when handling edits (#245183)
d13d387 
Fixes #242854
@vs-code-engineering vs-code-engineering bot added the unreleased Patch has not yet been released in VS Code Insiders label Mar 31, 2025
@vs-code-engineering vs-code-engineering bot added this to the April 2025 milestone Mar 31, 2025
@vs-code-engineering vs-code-engineering bot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DonJayamanne DonJayamanne

@connor4312 connor4312

Labels
chat debt Code quality issues insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Milestone
April 2025
Development

Successfully merging a pull request may close this issue.

chat: ensure we have just pushEdits when handling edits microsoft/vscode
2 participants
@DonJayamanne @connor4312