Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCM - commit message box uses the wrong cursor (can be hard to see) #242901

Closed
jacekkopecky opened this issue Mar 7, 2025 · 5 comments
Closed
Assignees
Labels
feature-request Request for new features or functionality scm General SCM compound issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@jacekkopecky
Copy link
Contributor

The SCM/git commit message editor uses a subset of cursor settings, which, in my case, makes it hard to see.

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.98.0 and latest build from main
  • OS Version: Mac and Windows both, not OS-specific

Steps to Reproduce:

  1. override cursor style (e.g. block, or width 4) in settings
  2. override cursor color in settings.json workbench.colorCustomizations (e.g. "#0d0f")
  3. check that the cursor is the correct style and color in text editor
  4. check that other fields (e.g. search) do not use the overridden cursor but platform default
  5. check that SCM/git commit message edit field uses a thin line cursor in your color rather than your overridden style/width or the platform default

The reason for this bug is that the git commit message uses a monaco editor and not a textarea, so it's affected by the color setting from your theme override but it does not import cursor style or width from the settings.

The gif below shows my green block non-blinking cursor in text editor, default blinking black line cursor in the search field, and a thin green non-blinking cursor in the git commit message. My eyesight is bad, and the commit window cursor is hard to see for me.

Image

@lszomoru lszomoru added suggest IntelliSense, Auto Complete scm General SCM compound issues feature-request Request for new features or functionality and removed suggest IntelliSense, Auto Complete labels Mar 7, 2025
@lszomoru lszomoru added this to the March 2025 milestone Mar 7, 2025
@lszomoru lszomoru changed the title SCM/git commit message box uses the wrong cursor (can be hard to see) SCM - commit message box uses the wrong cursor (can be hard to see) Mar 7, 2025
@lszomoru
Copy link
Member

Verification steps:

  • Modify the editor.cursorStyle, and editor.cursorWidth settings
  • Confirm that the cursor style/width in the editor matches the cursor style/width in the commit input box

@lszomoru lszomoru added the verification-needed Verification of issue is requested label Mar 24, 2025
@meganrogge meganrogge added the verified Verification succeeded label Mar 25, 2025
@meganrogge
Copy link
Contributor

meganrogge commented Mar 25, 2025

@lszomoru neither seem to work for me

Screen.Recording.2025-03-25.at.12.54.25.PM.mov

@meganrogge meganrogge reopened this Mar 25, 2025
@meganrogge meganrogge added verification-found Issue verification failed and removed verified Verification succeeded labels Mar 25, 2025
@jacekkopecky
Copy link
Contributor Author

@meganrogge thanks for catching that - @lszomoru it's not reacting to settings changes. It needs this around line 1500 in src/vs/workbench/contrib/scm/browser/scmViewPane.ts

		const onDidChangeConfiguration = Event.filter(
			this.configurationService.onDidChangeConfiguration,
			e => {
				return e.affectsConfiguration('editor.accessibilitySupport') ||
					e.affectsConfiguration('editor.cursorBlinking') ||
+					e.affectsConfiguration('editor.cursorStyle') ||
+					e.affectsConfiguration('editor.cursorWidth') ||
					e.affectsConfiguration('editor.emptySelectionClipboard') ||
					e.affectsConfiguration('editor.fontFamily') ||
					e.affectsConfiguration('editor.rulers') ||
					e.affectsConfiguration('editor.wordWrap') ||
					e.affectsConfiguration('scm.inputFontFamily') ||
					e.affectsConfiguration('scm.inputFontSize');
			},
			this._disposables
		);

Sorry that I missed that.

@lszomoru
Copy link
Member

@jacekkopecky, no worries. I have pushed a fix which should be in tomorrow's VS Code Insiders release.

@lszomoru lszomoru removed the verification-found Issue verification failed label Mar 26, 2025
@osortega osortega added the unreleased Patch has not yet been released in VS Code Insiders label Mar 26, 2025
@vs-code-engineering vs-code-engineering bot removed the unreleased Patch has not yet been released in VS Code Insiders label Mar 27, 2025
Copy link

Issue marked as unreleased but unable to locate closing commit in issue timeline. You can manually reference a commit by commenting \closedWith someCommitSha, or directly add the insiders-released label if you know this has already been released

@rzhao271 rzhao271 added the verified Verification succeeded label Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality scm General SCM compound issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants