-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SCM - commit message box uses the wrong cursor (can be hard to see) #242901
Comments
Verification steps:
|
@lszomoru neither seem to work for me Screen.Recording.2025-03-25.at.12.54.25.PM.mov |
@meganrogge thanks for catching that - @lszomoru it's not reacting to settings changes. It needs this around line 1500 in src/vs/workbench/contrib/scm/browser/scmViewPane.ts const onDidChangeConfiguration = Event.filter(
this.configurationService.onDidChangeConfiguration,
e => {
return e.affectsConfiguration('editor.accessibilitySupport') ||
e.affectsConfiguration('editor.cursorBlinking') ||
+ e.affectsConfiguration('editor.cursorStyle') ||
+ e.affectsConfiguration('editor.cursorWidth') ||
e.affectsConfiguration('editor.emptySelectionClipboard') ||
e.affectsConfiguration('editor.fontFamily') ||
e.affectsConfiguration('editor.rulers') ||
e.affectsConfiguration('editor.wordWrap') ||
e.affectsConfiguration('scm.inputFontFamily') ||
e.affectsConfiguration('scm.inputFontSize');
},
this._disposables
); Sorry that I missed that. |
@jacekkopecky, no worries. I have pushed a fix which should be in tomorrow's VS Code Insiders release. |
Issue marked as unreleased but unable to locate closing commit in issue timeline. You can manually reference a commit by commenting |
The SCM/git commit message editor uses a subset of cursor settings, which, in my case, makes it hard to see.
Does this issue occur when all extensions are disabled?: Yes
Steps to Reproduce:
workbench.colorCustomizations
(e.g. "#0d0f")The reason for this bug is that the git commit message uses a monaco editor and not a textarea, so it's affected by the color setting from your theme override but it does not import cursor style or width from the settings.
The gif below shows my green block non-blinking cursor in text editor, default blinking black line cursor in the search field, and a thin green non-blinking cursor in the git commit message. My eyesight is bad, and the commit window cursor is hard to see for me.
The text was updated successfully, but these errors were encountered: