Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility: In latest insider versions, NVDA repeats the penultimate line of the editor if the last line is empty. #244216

Open
adkurz opened this issue Mar 21, 2025 · 15 comments · Fixed by #244852
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug editor-edit-context
Milestone

Comments

@adkurz
Copy link

adkurz commented Mar 21, 2025

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.99.0-insider (user setup)
    Commit: 90dde06
  • OS Version: Windows 11, Version 24H2 (Build 26100.3476)

Steps to Reproduce:

  1. Install the latest insider version of VSCode
  2. Install NVDA (2024.4.2 or latest alpha) or use a portable version..
  3. Open a new editor in vscode.
  4. Write some text like "test".
  5. Press enter to create a new line.
  6. Instead of saying "empty", NVDA repeats the above line ("test").

This problem occurs if the last line in the editor is empty and has no white spaces. In older versions of VSCode, like current stable version, everything works fine. Even with all extensions disabled, the problem still exists.

@meganrogge
Copy link
Contributor

meganrogge commented Mar 21, 2025

Thanks for creating this issue! To help us narrow down what change caused the issue, please run the following command to find the build. It will start previous releases of VS Code insiders to see where the regression was introduced:

  • npx --yes npx @vscode/vscode-bisect@latest
  • follow the instructions until you found the offending build
  • report back the commit range in this issue

Thanks!

/label info-needed

@vs-code-engineering vs-code-engineering bot added the info-needed Issue requires more information from poster label Mar 21, 2025
@adkurz
Copy link
Author

adkurz commented Mar 21, 2025

I installed NodeJS, I have no Experience with it. If I enter the npx command, I get following error message:

npm error code ETARGET
npm error notarget No matching version found for vscode-bisect@latest.
npm error notarget In most cases you or one of your dependencies are requesting
npm error notarget a package version that doesn't exist.

@meganrogge
Copy link
Contributor

what's your node version?

@meganrogge
Copy link
Contributor

@rperez030 does this reproduce for you? I do not have access to windows. It does not reproduce on mac using VoiceOver.

@christopherpross
Copy link

Hello everyone,

I can reliably reproduce this bug and executed the suggested command:

npx --yes @vscode/vscode-bisect@latest

with the latest Node.js version (23.10.0).

This produced the following output:

[build] 6d98db08819f07a8541bfb396be1b0e6819f5d71 is the first bad commit after 6609ac3d66f4eade5cf376d1cb76f13985724bcb.

By the way, the bisect tool (and the idea behind it) is really helpful. Just make sure to use the latest Node.js version to avoid issues.

For those who have VSCode checked out from git, here are the additional commands provided by the tool to continue bisecting:

git bisect start && git bisect bad 6d98db08819f07a8541bfb396be1b0e6819f5d71 && git bisect good 6609ac3d66f4eade5cf376d1cb76f13985724bcb                                                                                                         

If I can assist further, please let me know.

@meganrogge
Copy link
Contributor

cc @bpasero 6d98db0

any idea why that would cause this?

@meganrogge
Copy link
Contributor

@bpasero reminded me that is just a commit range to go through - I do not have access to windows at the moment. @christopherpross would you be able to run git bisect start && git bisect bad 6d98db08819f07a8541bfb396be1b0e6819f5d71 && git bisect good 6609ac3d66f4eade5cf376d1cb76f13985724bcb to further narrow this down?

@meganrogge
Copy link
Contributor

@aiday-mar I see a commit in that range that might be related #241189

@christopherpross
Copy link

@bpasero reminded me that is just a commit range to go through - I do not have access to windows at the moment. @christopherpross would you be able to run git bisect start && git bisect bad 6d98db08819f07a8541bfb396be1b0e6819f5d71 && git bisect good 6609ac3d66f4eade5cf376d1cb76f13985724bcb to further narrow this down?

Hey,
I tried this at this moment, but I have problems with the dependencies, I can't install the dependencies for VS code at this moment. Seems to be the C++ libs.

@aiday-mar
Copy link
Contributor

Hi thank you for filing this issue. May I ask you if you see this happen with the setting editor.experimentalEditContextEnabled disabled? If yes then this could be an edit context bug.

@adkurz
Copy link
Author

adkurz commented Mar 25, 2025

With this setting disabled, the problem is gone.

@aiday-mar
Copy link
Contributor

Hi thanks for letting me know. I will have a look at this.

@meganrogge meganrogge removed the info-needed Issue requires more information from poster label Mar 25, 2025
@aiday-mar
Copy link
Contributor

Interestingly as the author points out, this only happens when the last line does not contain whitespaces. If the last line contains whitespaces, the screen reader reads 'blank' correctly.

@vs-code-engineering vs-code-engineering bot added the unreleased Patch has not yet been released in VS Code Insiders label Mar 27, 2025
@vs-code-engineering vs-code-engineering bot added this to the March 2025 milestone Mar 27, 2025
@vs-code-engineering vs-code-engineering bot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Mar 28, 2025
@adkurz
Copy link
Author

adkurz commented Apr 4, 2025

In the latest insiders build (1.100.0-insider (user setup)
Commit: c7ea9f8) the problem still exists. For me, the, nothing has changed if the edit context is enabled.

@aiday-mar
Copy link
Contributor

I see thank you for letting me know. I will reopen this issue.

@aiday-mar aiday-mar reopened this Apr 4, 2025
@aiday-mar aiday-mar added the bug Issue identified by VS Code Team member as probable bug label Apr 4, 2025
@vs-code-engineering vs-code-engineering bot removed the insiders-released Patch has been released in VS Code Insiders label Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug editor-edit-context
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants