-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding policy requires a restart of vs code to apply #244531
Comments
Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.98.2. Please try upgrading to the latest version and checking whether this issue remains. Happy Coding! |
Seems to be a regression caused by MultiplexePolicyService |
I thought i'd noticed this behavior earlier in the month (before the multiplex changes landed). When the change lands it is probably worth testing on linux (where we wouldn't instantiate a multiplexpolicyservice, just an accountpolicyservice) |
Demo of this repro'ing on macOS in today's insiders (ff52a0d): Screen.Recording.2025-03-27.at.2.44.09.PM.movThe underlying native policy watcher does pick up changes instantly, so the issue appears to be in vscode itself: Screen.Recording.2025-03-27.at.2.46.38.PM.mov |
@joshspicer It is not easy to follow the video. Can you please share the steps to reproduce? Please also share the trace logs from main and window which contain information about policy changes. Also, looks like chat related policies will be always overridden by the account policy right? |
|
This issue does not repro when using the FilePolicyService in place of NativePolicyService Screen.Recording.2025-03-28.at.10.08.30.AM.mov |
Fix: #244996 This bug has been here for a while, but I think it went under the radar due to the lack of policies that existed. This month we have many more policies contributed from many places, and therefore the bug is more pronounced. This is consistently the final "update" I've observed under the debugger, therefore (before the fix) only that one policy would have been watched by the native policy watcher |
/closedWith 99c9c6c |
Does this issue occur when all extensions are disabled?: Yes/No
Similar to microsoft/vscode-policy-watcher#47 but the issue is in core instead of this policy-watcher.
Steps to Reproduce:
The text was updated successfully, but these errors were encountered: