Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feedback: before / after selectors not rendering correctly #244575

Closed
mrleemurray opened this issue Mar 25, 2025 · 0 comments · Fixed by #245645
Closed

Feedback: before / after selectors not rendering correctly #244575

mrleemurray opened this issue Mar 25, 2025 · 0 comments · Fixed by #245645
Assignees
@alexr00
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders tree-sitter
Milestone
April 2025

Comments

@mrleemurray
Copy link
Contributor

Testing #244445

Before & After psuedo-element selectors (specifically the double colons) rendering differently in Insiders.

Snippet:

.border span::after {
	top: -2px;
}
.border span::before {
	bottom: -2px;
}

Insiders

Image

Stable

Image

Theme: Dark+
@amunger amunger removed their assignment Mar 25, 2025
@alexr00 alexr00 added bug Issue identified by VS Code Team member as probable bug tree-sitter labels Apr 2, 2025
@alexr00 alexr00 added this to the April 2025 milestone Apr 2, 2025
alexr00 added a commit that referenced this issue Apr 4, 2025
@alexr00
Feedback: before / after selectors not rendering correctly
d88e9f5 
Fixes #244575
@alexr00 alexr00 mentioned this issue Apr 4, 2025
Merged
alexr00 added a commit that referenced this issue Apr 4, 2025
@alexr00
Feedback: before / after selectors not rendering correctly (#245645)
90dba36 
Fixes #244575
@vs-code-engineering vs-code-engineering bot added the unreleased Patch has not yet been released in VS Code Insiders label Apr 4, 2025
lszomoru pushed a commit that referenced this issue Apr 5, 2025
@alexr00 @lszomoru
Feedback: before / after selectors not rendering correctly (#245645)
616fc8b 
Fixes #244575
lszomoru added a commit that referenced this issue Apr 6, 2025
@lszomoru @bpasero
@alexr00 @deepak1556 @benibenj @hediet @mdanish-kh @aiday-mar @aeschli
Engineering - background codesign for Windows stage (#245796)
e1ff10f 
* Add zx package

* Add stub task and script

* Add missing file

* Remove code

* Another try

* Fingers crossed

* Another try

* Add remaining steps

* Add back tasks

* Fix things

* Another try

* More fixes

* Use deemon

* Fixing things

* watcher - perf improvements for non-recursive watching (#245644)

* Feedback: before / after selectors not rendering correctly (#245645)

Fixes #244575

* Add highlights rule  for character escapes (#245647)

* ci: split gnu arm targets for cli stage (#245651)

* Fix inline edit acceptance on click (#245649)

fix clicking insertion does not accept

* Feedback: variables render differently in Insiders (#245650)

Fixes #244579

* !important different color (#245654)

Fixes #244632

* @Property css different color (#245656)

Fixes #244634

* > different color (#245658)

Fixes #244631

* notifications - adopt more `NotificationPriority.OPTIONAL` (#245664)

* Adds more inline completion tests

* Fixes CI

* feat: enable gpu channel async from the runtime (#241640)

* Update WinGet configuration file location & extension (#242241)

* Update WinGet configuration file location & extension

* Remove prerelease: true & add securityContext

* High CPU on large workspace with many TypeScript watched folders (fix #245366) (#245670)

* High CPU on large workspace with many TypeScript watched folders (fix #245366)

* reduce throttle delay

* Moving away from `execCommand` for pasting (#239233)

* adding code to invetsigate the clipboard

* adding more code

* adding change

* adding logs

* adding notes

* making deubgging easier

* adding code to fix paste

* adding code to allow await before trigger paste

* removing all logs

* removing log

* refactoring

* removing change

* adding fix after call

* polishing

* fixing merge conflict

* polishing

* Fixing property initializiation order (#245673)

fixing property initializiation order

* voice - fix some leaks (#245676)

* update css service (#245688)

* Engineering - bump deemon (#245634)

* Engineering - bump deemon

* Bump deemon again

* Always run the Codesign post-job

* Another fix

* Try signing in parallel

* Clean up signing script

Update task name

Tweak script

Some more cleanup

Some more cleanup

More cleanup

* Attempt to run signing in parallel

---------

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
Co-authored-by: Alex Ross <38270282+alexr00@users.noreply.github.com>
Co-authored-by: Robo <hop2deep@gmail.com>
Co-authored-by: Benjamin Christopher Simmonds <44439583+benibenj@users.noreply.github.com>
Co-authored-by: Henning Dieterichs <hdieterichs@microsoft.com>
Co-authored-by: Muhammad Danish <mdanishkhdev@gmail.com>
Co-authored-by: Aiday Marlen Kyzy <amarlenkyzy@microsoft.com>
Co-authored-by: Martin Aeschlimann <martinae@microsoft.com>
@vs-code-engineering vs-code-engineering bot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders tree-sitter
Projects
None yet
Milestone
April 2025
Development

Successfully merging a pull request may close this issue.

Feedback: before / after selectors not rendering correctly microsoft/vscode
3 participants
@amunger @mrleemurray @alexr00