Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error not obvious when MCP server fails to start. #244629

Closed
bhavyaus opened this issue Mar 25, 2025 · 4 comments · Fixed by #245267
Closed

Error not obvious when MCP server fails to start. #244629

bhavyaus opened this issue Mar 25, 2025 · 4 comments · Fixed by #245267
Assignees
@connor4312
Labels
bug Issue identified by VS Code Team member as probable bug chat-mcp insiders-released Patch has been released in VS Code Insiders
Milestone
April 2025

Comments

@bhavyaus
Copy link
Collaborator

bhavyaus commented Mar 25, 2025 •
edited
Loading

Steps to Reproduce:

  1. Add an mcp server which needs an API key.
  2. Fail to include the api key in the env variables.
  3. Start the server from the ▶️Start codelen
  4. Server Starts and then stops running due to the error.
  5. No obvious error indicators which call out why we stopped.

Found when testing: #244521
@connor4312 connor4312 added the info-needed Issue requires more information from poster label Mar 25, 2025
@connor4312
Copy link
Member

Clicking on the Error code lens or the red ⚠️ error indicator in chat should open the server output which should print something useful about the API key being wrong if the server behaves well. Do you see that UI?

@bhavyaus
Copy link
Collaborator Author

I didnt see an Error in the code lens which is why I was confused :( . I do see the error if I go the chat route.

@bhavyaus
Copy link
Collaborator Author

Here's a repro:

Screen.Recording.2025-03-25.at.10.48.48.mov

@connor4312 connor4312 mentioned this issue Mar 25, 2025
Closed
@connor4312
Copy link
Member

Ah, I see. We should mark it as an error if a server stops without responding to the initialize request.

@connor4312 connor4312 added bug Issue identified by VS Code Team member as probable bug chat-mcp and removed info-needed Issue requires more information from poster labels Mar 25, 2025
connor4312 added a commit that referenced this issue Apr 1, 2025
@connor4312
mcp: fix error not obvious when MCP server fails to start
5983797 
Fixes #244629
@connor4312 connor4312 mentioned this issue Apr 1, 2025
Merged
connor4312 added a commit that referenced this issue Apr 1, 2025
@connor4312
mcp: fix error not obvious when MCP server fails to start (#245267)
029d6a3 
Fixes #244629
@vs-code-engineering vs-code-engineering bot added the unreleased Patch has not yet been released in VS Code Insiders label Apr 1, 2025
@vs-code-engineering vs-code-engineering bot added this to the April 2025 milestone Apr 1, 2025
@vs-code-engineering vs-code-engineering bot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@connor4312 connor4312

Labels
bug Issue identified by VS Code Team member as probable bug chat-mcp insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Milestone
April 2025
Development

Successfully merging a pull request may close this issue.

mcp: fix error not obvious when MCP server fails to start microsoft/vscode
2 participants
@connor4312 @bhavyaus