Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Select Tools..." should not show when there are no tools #244748

Closed
jrieken opened this issue Mar 26, 2025 · 3 comments
Closed

"Select Tools..." should not show when there are no tools #244748

jrieken opened this issue Mar 26, 2025 · 3 comments
Assignees
@jrieken
Labels
chat-mcp insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
March 2025

Comments

@jrieken
Copy link
Member

jrieken commented Mar 26, 2025 •
edited
Loading

Saw this in @isidorn demo, seems like "Select Tools..." despite there being no tools. This should not happen.

image
@jrieken jrieken self-assigned this Mar 26, 2025
@jrieken jrieken added this to the March 2025 milestone Mar 26, 2025
@jrieken jrieken added bug Issue identified by VS Code Team member as probable bug chat-mcp labels Mar 26, 2025
jrieken added a commit that referenced this issue Mar 26, 2025
@jrieken
fix #244748
c12995e
@vs-code-engineering vs-code-engineering bot added the unreleased Patch has not yet been released in VS Code Insiders label Mar 26, 2025
@vs-code-engineering vs-code-engineering bot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Mar 27, 2025
jrieken added a commit that referenced this issue Mar 27, 2025
@jrieken
Revert "fix #244748 (#244753)"
fb0b187 
This reverts commit 49f5181.
jrieken added a commit that referenced this issue Mar 27, 2025
@jrieken
always render Select Tools with icon, always show it (in agent mode) (#…
36762fc 
…244850)

* Revert "fix #244748 (#244753)"

This reverts commit 49f5181.

* always render Select Tools with icon, always show it (in agent mode)

microsoft/vscode-copilot#15019
@eleanorjboyd eleanorjboyd added the verification-steps-needed Steps to verify are needed for verification label Mar 27, 2025
@eleanorjboyd
Copy link
Member

not seeing this UI? Is this sidebar, unified chat, with agent mode?

@amunger
Copy link
Contributor

amunger commented Mar 27, 2025

Still shows, but now there are actions to be taken, so that makes sense. Let me know if there's something else to verify.

Image

@amunger amunger added verified Verification succeeded and removed verification-steps-needed Steps to verify are needed for verification labels Mar 27, 2025
@jrieken jrieken removed the bug Issue identified by VS Code Team member as probable bug label Mar 28, 2025
@jrieken
Copy link
Member Author

jrieken commented Mar 28, 2025 •
edited
Loading

we actually changed that it will now always show

@jrieken jrieken removed the verified Verification succeeded label Mar 28, 2025
@eleanorjboyd eleanorjboyd added the verified Verification succeeded label Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrieken jrieken

Labels
chat-mcp insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
March 2025
Development

No branches or pull requests
3 participants
@jrieken @amunger @eleanorjboyd