Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extra "add server" button in chat a11y view #244770

Closed
amunger opened this issue Mar 26, 2025 · 1 comment · Fixed by #245287
Closed

extra "add server" button in chat a11y view #244770

amunger opened this issue Mar 26, 2025 · 1 comment · Fixed by #245287
Assignees
@connor4312 @meganrogge
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders
Milestone
April 2025

Comments

@amunger
Copy link
Collaborator

amunger commented Mar 26, 2025

Steps to Reproduce:

  1. add an mcp server and then keep the mcp.json open, or just open the mcp.json file
  2. focus on a copilot chat response and press alt+f2 to open the a11y view

🐛 extra button in the view (I can't even tab to it, so I assume it shouldn't be there)

Image
@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues labels Mar 26, 2025
@meganrogge
Copy link
Contributor

@connor4312 we should make an accessible view specific to this type of editor so we can add the action to add server in the toolbar

@meganrogge meganrogge mentioned this issue Mar 27, 2025
Closed
connor4312 added a commit that referenced this issue Apr 1, 2025
@connor4312
a11y: don't show floating click menu in accessible view
c616b90 
Fixes #244770
@connor4312 connor4312 mentioned this issue Apr 1, 2025
Merged
@vs-code-engineering vs-code-engineering bot added the unreleased Patch has not yet been released in VS Code Insiders label Apr 1, 2025
@vs-code-engineering vs-code-engineering bot added this to the April 2025 milestone Apr 1, 2025
@vs-code-engineering vs-code-engineering bot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@connor4312 connor4312

@meganrogge meganrogge

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Milestone
April 2025
Development

Successfully merging a pull request may close this issue.

a11y: don't show floating click menu in accessible view microsoft/vscode
3 participants
@amunger @connor4312 @meganrogge