Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Welcome view flicker when loading chat in agent mode #244936

Closed
roblourens opened this issue Mar 27, 2025 · 4 comments · Fixed by #244937
Closed

Welcome view flicker when loading chat in agent mode #244936

roblourens opened this issue Mar 27, 2025 · 4 comments · Fixed by #244937
Assignees
@roblourens
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release chat insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
March 2025

Comments

@roblourens
Copy link
Member

Screen.Recording.2025-03-27.at.3.59.39.PM.mov

The real agent welcome diverged from the setup agent's. Candidate because it's ugly
@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release chat labels Mar 27, 2025
@roblourens roblourens added this to the March 2025 milestone Mar 27, 2025
@roblourens roblourens self-assigned this Mar 27, 2025
roblourens added a commit that referenced this issue Mar 27, 2025
@roblourens
Align setup and extension welcome view content to avoid flicker
3356a4b 
Fix #244936
@roblourens roblourens mentioned this issue Mar 27, 2025
Merged
@bpasero
Copy link
Member

bpasero commented Mar 28, 2025

Thanks, yeah unfortunately we need to play catch up game here...

bpasero added a commit that referenced this issue Mar 28, 2025
@bpasero
Welcome view flicker when loading chat in agent mode (#244936)
37a4182
bpasero added a commit that referenced this issue Mar 28, 2025
@bpasero
Welcome view flicker when loading chat in agent mode (#244936) (#244962)
105a5e2
@roblourens
Copy link
Member Author

roblourens commented Mar 28, 2025 •
edited
Loading

I'd like to have one source of truth for this, however the extension has the extra quirk of introducing this dynamic message about telemetry for internal users, not sure if we have the info to apply that on the core side

@bpasero
Copy link
Member

bpasero commented Mar 28, 2025 •
edited
Loading

That is only for MSFT internal right? But I do agree that we should try to move this out entirely from the extension if possible.

@TylerLeonhardt
Copy link
Member

/closedWith 23192aa

@vs-code-engineering vs-code-engineering bot added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Mar 28, 2025
@rzhao271 rzhao271 added the verified Verification succeeded label Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roblourens roblourens

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release chat insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
March 2025
Development

Successfully merging a pull request may close this issue.

Align setup and extension welcome view content to avoid flicker microsoft/vscode
4 participants
@roblourens @bpasero @TylerLeonhardt @rzhao271