Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dialog dismissOnLinkClick is problematic #245162

Closed
bpasero opened this issue Mar 31, 2025 · 0 comments · Fixed by #245173
Closed

Dialog dismissOnLinkClick is problematic #245162

bpasero opened this issue Mar 31, 2025 · 0 comments · Fixed by #245173
Assignees
@bpasero @connor4312
Labels
debt Code quality issues dialogs Issues with native and custom dialogs insiders-released Patch has been released in VS Code Insiders ux User experience issues
Milestone
April 2025

Comments

@bpasero
Copy link
Member

bpasero commented Mar 31, 2025

Coming across dismissOnLinkClick for dialogs:

vscode/src/vs/platform/dialogs/common/dialogs.ts

Line 286 in c54bb3d

readonly dismissOnLinkClick?: boolean;

I find this problematic because as a user I do not know:

  • which of the dialog buttons was now considered, if at all
  • how to get back to the dialog

If the intent is to open a file and make it visible, please consider the AUX_WINDOW_GROUP option in openEditor to open in a new floating window.
@bpasero bpasero added the dialogs Issues with native and custom dialogs label Mar 31, 2025
@bpasero bpasero added this to the April 2025 milestone Mar 31, 2025
@bpasero bpasero added debt Code quality issues ux User experience issues labels Mar 31, 2025
@connor4312 connor4312 mentioned this issue Mar 31, 2025
Closed
connor4312 added a commit that referenced this issue Mar 31, 2025
@connor4312
mcp: open to-trust config in aux window instead of main window
b9d152d 
Fixes #245162
@connor4312 connor4312 mentioned this issue Mar 31, 2025
Merged
connor4312 added a commit that referenced this issue Mar 31, 2025
@connor4312
mcp: open to-trust config in aux window instead of main window
99d5a8d 
Fixes #245162
@vs-code-engineering vs-code-engineering bot added the unreleased Patch has not yet been released in VS Code Insiders label Apr 1, 2025
@vs-code-engineering vs-code-engineering bot added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bpasero bpasero

@connor4312 connor4312

Labels
debt Code quality issues dialogs Issues with native and custom dialogs insiders-released Patch has been released in VS Code Insiders ux User experience issues
Projects
None yet
Milestone
April 2025
Development

Successfully merging a pull request may close this issue.

mcp: open to-trust config in aux window instead of main window microsoft/vscode
2 participants
@bpasero @connor4312