Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LCD appears broken #55

Open
sofar opened this issue Mar 6, 2019 · 4 comments
Open

LCD appears broken #55

sofar opened this issue Mar 6, 2019 · 4 comments

Comments

@sofar
Copy link
Member

sofar commented Mar 6, 2019

After all the merges, it appears the LCD no longer functions properly, and I don't understand why.

@numberZero @DS-Minetest

@Desour
Copy link
Contributor

Desour commented Mar 6, 2019

I can't find any problems at testing with a newly placed lcd.
Could you describe the problem more precisely? Steps to reproduce would be helpful.

@sofar
Copy link
Member Author

sofar commented Mar 10, 2019

Old LCD displays no longer worked. All I did was hook up a chest to a LCD screen to quickly see if taking out/storing items produces the expected text.

@Desour
Copy link
Contributor

Desour commented Mar 10, 2019

Ah, I see.
It's not the lcd that makes problems but the digiline chest. It now sends tables instead of strings.

Change from sending strings to sending tables.

#49

This means that old constructions won't work anymore.
I'm not sure if this really is a big problem.
There might be some ugly and hacky ways to fix this, but reworks can break things, I think this is ok but players should be informed in some way.

(I'm sorry that I haven't spent again time to review that PR btw. >_<)

@Hawk777

@Hawk777
Copy link
Contributor

Hawk777 commented Mar 10, 2019

Ah, yes, that was my change, wasn’t it? Yes, it does unfortunately break existing builds, but I submitted it thinking that the improvement was worthwhile (IMO the old string-based message format simply didn’t give enough information to do some of the useful things with Digilines chests that people might want, and expanding the string-based format would break existing parsers anyway, so why not just switch to tables while we’re at it?). I didn’t realize people would directly connect a Digilines chest to an LCD without an intervening Luacontroller, and it’s true that doesn’t work any more.

As far as informing players, does Digilines have a news page, changelog, or something? I’m not a member of the Minetest forum; maybe that’s where the info is supposed to go?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants