Fix a memory leak in Signaller.ProcessSignalQueue due to an unclosed response body (#67)

mqmr · web-flow · commit 2e455bfcc450 · 2021-04-06T15:37:37.000+02:00
diff --git a/pkg/signaller/run.go b/pkg/signaller/run.go
@@ -68,6 +68,12 @@ func (b *Signaller) ProcessSignalQueue() {
 		} else {
 			glog.V(5).Infof("recieved a signal response from %s: %+v", response.Request.URL.Host, response)
 		}
+
+		if response != nil {
+			if err := response.Body.Close(); err != nil {
+				glog.Error("error on closing response body:", err)
+			}
+		}
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -68,6 +68,12 @@ func (b *Signaller) ProcessSignalQueue() {`
`68`	`68`	`} else {`
`69`	`69`	`glog.V(5).Infof("recieved a signal response from %s: %+v", response.Request.URL.Host, response)`
`70`	`70`	`}`
	`71`	`+`
	`72`	`+ if response != nil {`
	`73`	`+ if err := response.Body.Close(); err != nil {`
	`74`	`+ glog.Error("error on closing response body:", err)`
	`75`	`+ }`
	`76`	`+ }`
`71`	`77`	`}`
`72`	`78`	`}`
`73`	`79`