Skip to content

Commit c17e9b8

Browse files
Apply suggestions from code review
Co-authored-by: Boris Zbarsky <bzbarsky@apple.com>
1 parent ba12515 commit c17e9b8

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/app/icd/server/ICDManager.cpp

+2-2
Original file line numberDiff line numberDiff line change
@@ -249,8 +249,8 @@ bool ICDManager::CheckInWouldBeSentAtActiveModeVerifier(FabricIndex aFabricIndex
249249
VerifyOrReturnValue(mSubInfoProvider->SubjectHasActiveSubscription(aFabricIndex, subjectID), true);
250250

251251
#if CHIP_CONFIG_PERSIST_SUBSCRIPTIONS
252-
// At least one registration has a persisted entry. Do not send Check-In message.
253-
// This is to cover the use-case where the subscription resumption feature is used with the Check-In message.
252+
// If at least one registration has a persisted entry, do not send Check-In message.
253+
// The resumption of the persisted subscription will serve the same function a check-in would have served.
254254
VerifyOrReturnValue(mSubInfoProvider->SubjectHasPersistedSubscription(aFabricIndex, subjectID), true);
255255
#endif // CHIP_CONFIG_PERSIST_SUBSCRIPTIONS
256256
return false;

src/app/icd/server/ICDManager.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ class ICDManager : public ICDListener
8585
* This type can be used to implement specific verifiers that can be used in the CheckInMessagesWouldBeSent function.
8686
* The goal is to avoid having multiple functions that implement the iterator loop with only the check changing.
8787
*
88-
* @return true if at least one Check-In message wuld be sent
88+
* @return true if at least one Check-In message would be sent
8989
* false No Check-In messages would be sent
9090
*/
9191

0 commit comments

Comments
 (0)