Skip to content

Commit 84a33d7

Browse files
authored
Merge pull request #9 from slangbot/format-6529-bugfix/shader-slanggh-6513
Format code for PR shader-slang#6529
2 parents 19d24b5 + c6d4315 commit 84a33d7

File tree

7 files changed

+38
-21
lines changed

7 files changed

+38
-21
lines changed

source/compiler-core/slang-downstream-compiler.h

+4-2
Original file line numberDiff line numberDiff line change
@@ -401,8 +401,10 @@ class DownstreamCompilerBase : public ComBaseObject, public IDownstreamCompiler
401401
return SLANG_FAIL;
402402
}
403403

404-
virtual SLANG_NO_THROW SlangResult SLANG_MCALL
405-
disassembleWithResult(const uint32_t* contents, int contentsSize, String& outString) SLANG_OVERRIDE
404+
virtual SLANG_NO_THROW SlangResult SLANG_MCALL disassembleWithResult(
405+
const uint32_t* contents,
406+
int contentsSize,
407+
String& outString) SLANG_OVERRIDE
406408
{
407409
SLANG_UNUSED(contents);
408410
SLANG_UNUSED(contentsSize);

source/compiler-core/slang-glslang-compiler.cpp

+10-5
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,10 @@ class GlslangDownstreamCompiler : public DownstreamCompilerBase
4949
validate(const uint32_t* contents, int contentsSize) SLANG_OVERRIDE;
5050
virtual SLANG_NO_THROW SlangResult SLANG_MCALL
5151
disassemble(const uint32_t* contents, int contentsSize) SLANG_OVERRIDE;
52-
virtual SLANG_NO_THROW SlangResult SLANG_MCALL
53-
disassembleWithResult(const uint32_t* contents, int contentsSize, String& outString) SLANG_OVERRIDE;
52+
virtual SLANG_NO_THROW SlangResult SLANG_MCALL disassembleWithResult(
53+
const uint32_t* contents,
54+
int contentsSize,
55+
String& outString) SLANG_OVERRIDE;
5456
int link(
5557
const uint32_t** modules,
5658
const uint32_t* moduleSizes,
@@ -89,8 +91,8 @@ SlangResult GlslangDownstreamCompiler::init(ISlangSharedLibrary* library)
8991
m_validate = (glslang_ValidateSPIRVFunc)library->findFuncByName("glslang_validateSPIRV");
9092
m_disassemble =
9193
(glslang_DisassembleSPIRVFunc)library->findFuncByName("glslang_disassembleSPIRV");
92-
m_disassembleWithResult =
93-
(glslang_DisassembleSPIRVWithResultFunc)library->findFuncByName("glslang_disassembleSPIRVWithResult");
94+
m_disassembleWithResult = (glslang_DisassembleSPIRVWithResultFunc)library->findFuncByName(
95+
"glslang_disassembleSPIRVWithResult");
9496
m_link = (glslang_LinkSPIRVFunc)library->findFuncByName("glslang_linkSPIRV");
9597

9698
if (m_compile_1_0 == nullptr && m_compile_1_1 == nullptr && m_compile_1_2 == nullptr)
@@ -321,7 +323,10 @@ SlangResult GlslangDownstreamCompiler::validate(const uint32_t* contents, int co
321323
return SLANG_FAIL;
322324
}
323325

324-
SlangResult GlslangDownstreamCompiler::disassembleWithResult(const uint32_t* contents, int contentsSize, String& outString)
326+
SlangResult GlslangDownstreamCompiler::disassembleWithResult(
327+
const uint32_t* contents,
328+
int contentsSize,
329+
String& outString)
325330
{
326331
if (m_disassembleWithResult == nullptr)
327332
{

source/slang-glslang/slang-glslang.cpp

+9-6
Original file line numberDiff line numberDiff line change
@@ -187,11 +187,14 @@ extern "C"
187187
// Disassemble the given SPIRV-ASM instructions and return the result as a string.
188188
extern "C"
189189
#ifdef _MSC_VER
190-
_declspec(dllexport)
190+
_declspec(dllexport)
191191
#else
192192
__attribute__((__visibility__("default")))
193193
#endif
194-
bool glslang_disassembleSPIRVWithResult(const uint32_t * contents, int contentsSize, char** outString)
194+
bool glslang_disassembleSPIRVWithResult(
195+
const uint32_t* contents,
196+
int contentsSize,
197+
char** outString)
195198
{
196199
static const auto kDefaultEnvironment = SPV_ENV_UNIVERSAL_1_5;
197200
spv_text text;
@@ -217,10 +220,10 @@ bool glslang_disassembleSPIRVWithResult(const uint32_t * contents, int contentsS
217220
if (outString)
218221
{
219222
// Allocate memory for the output string and copy the result
220-
size_t len = text->length + 1; // +1 for null terminator
223+
size_t len = text->length + 1; // +1 for null terminator
221224
*outString = new char[len];
222225
memcpy(*outString, text->str, text->length);
223-
(*outString)[text->length] = '\0'; // Ensure null termination
226+
(*outString)[text->length] = '\0'; // Ensure null termination
224227
}
225228

226229
spvTextDestroy(text);
@@ -232,11 +235,11 @@ bool glslang_disassembleSPIRVWithResult(const uint32_t * contents, int contentsS
232235
// Disassemble the given SPIRV-ASM instructions.
233236
extern "C"
234237
#ifdef _MSC_VER
235-
_declspec(dllexport)
238+
_declspec(dllexport)
236239
#else
237240
__attribute__((__visibility__("default")))
238241
#endif
239-
bool glslang_disassembleSPIRV(const uint32_t * contents, int contentsSize)
242+
bool glslang_disassembleSPIRV(const uint32_t* contents, int contentsSize)
240243
{
241244
return glslang_disassembleSPIRVWithResult(contents, contentsSize, nullptr);
242245
}

source/slang-glslang/slang-glslang.h

+4-1
Original file line numberDiff line numberDiff line change
@@ -166,6 +166,9 @@ typedef int (*glslang_CompileFunc_1_1)(glslang_CompileRequest_1_1* request);
166166
typedef int (*glslang_CompileFunc_1_2)(glslang_CompileRequest_1_2* request);
167167
typedef bool (*glslang_ValidateSPIRVFunc)(const uint32_t* contents, int contentsSize);
168168
typedef bool (*glslang_DisassembleSPIRVFunc)(const uint32_t* contents, int contentsSize);
169-
typedef bool (*glslang_DisassembleSPIRVWithResultFunc)(const uint32_t* contents, int contentsSize, char** outString);
169+
typedef bool (*glslang_DisassembleSPIRVWithResultFunc)(
170+
const uint32_t* contents,
171+
int contentsSize,
172+
char** outString);
170173
typedef bool (*glslang_LinkSPIRVFunc)(glslang_LinkRequest* request);
171174
#endif

source/slang-llvm/slang-llvm.cpp

+4-2
Original file line numberDiff line numberDiff line change
@@ -146,8 +146,10 @@ class LLVMDownstreamCompiler : public ComBaseObject, public IDownstreamCompiler
146146
SLANG_UNUSED(contentsSize);
147147
return SLANG_FAIL;
148148
}
149-
virtual SLANG_NO_THROW SlangResult SLANG_MCALL
150-
disassembleWithResult(const uint32_t* contents, int contentsSize, String& outString) SLANG_OVERRIDE
149+
virtual SLANG_NO_THROW SlangResult SLANG_MCALL disassembleWithResult(
150+
const uint32_t* contents,
151+
int contentsSize,
152+
String& outString) SLANG_OVERRIDE
151153
{
152154
SLANG_UNUSED(contents);
153155
SLANG_UNUSED(contentsSize);

source/slang/slang-ir.cpp

+6-4
Original file line numberDiff line numberDiff line change
@@ -7152,15 +7152,17 @@ static void dumpEmbeddedDownstream(IRDumpContext* context, IRInst* inst)
71527152
// Get the compiler from the session through the module
71537153
auto module = inst->getModule();
71547154
auto session = module->getSession();
7155-
IDownstreamCompiler* compiler = session->getOrLoadDownstreamCompiler(
7156-
PassThroughMode::SpirvDis,
7157-
nullptr);
7155+
IDownstreamCompiler* compiler =
7156+
session->getOrLoadDownstreamCompiler(PassThroughMode::SpirvDis, nullptr);
71587157

71597158
if (compiler)
71607159
{
71617160
// Use glslang interface to disassemble with string output
71627161
String disassemblyOutput;
7163-
if (SLANG_SUCCEEDED(compiler->disassembleWithResult(spirvCode, int(spirvWordCount), disassemblyOutput)))
7162+
if (SLANG_SUCCEEDED(compiler->disassembleWithResult(
7163+
spirvCode,
7164+
int(spirvWordCount),
7165+
disassemblyOutput)))
71647166
{
71657167
// Dump the captured disassembly
71667168
dump(context, "\n");

source/slang/slang.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -3752,7 +3752,7 @@ SlangResult EndToEndCompileRequest::executeActionsInner()
37523752
{
37533753
DiagnosticSinkWriter writer(frontEndReq->getSink());
37543754

3755-
dumpIR(
3755+
dumpIR(
37563756
translationUnit->getModule()->getIRModule(),
37573757
frontEndReq->m_irDumpOptions,
37583758
"PRECOMPILE_FOR_TARGET_COMPLETE_ALL",

0 commit comments

Comments
 (0)