Fix boolean transformer error #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@rrgks6221 @ohchanghoon pr 다시 열었습니다. |
rrgks6221
reviewed
Feb 11, 2024
Comment on lines
2
to
6
| return value === 'true' || value === '1' | ||
| ? true | ||
| : value === 'false' || value === '0' | ||
| ? false | ||
| : value; |
There was a problem hiding this comment.
상항연산자가 2개 이상 들어갈때는 if문이 더 단순하게 짜여질 수 있으니 고려해보면 좋을듯합니다.
| @@ -0,0 +1,7 @@ | |||
| export function transformStringToBoolean({ value }) { | |||
There was a problem hiding this comment.
순수한 js function이여서 testcode 연습겸 짜보면 좋을거같아요
rrgks6221
approved these changes
Feb 11, 2024
ohchanghoon
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
기존에 BooleanString인지 검사하고 boolean으로 transform 하는 로직에 에러가 있었어서 이를 고쳤습니다.
To Reviewer
validator와 transformer중 transformer가 먼저 실행됨.(그 와중에 무조건 어떤 값이든 true로 변환시킴)
먼저 transformer로 mapper 내에 존재하는 값으로 변환시킴('undefined' --> undefined, 'true' --> true, 'false' --> false)
그 후 IsBoolean validator로 검사
Reference Link
typestack/class-transformer#676
Related Issue Link
QYOG-68
API