post 관련 리소스 변수명 간소화 #136
Merged
post 관련 리소스 변수명 간소화 #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
이슈 링크가 안타져오 |
수정했씁니다. |
hobiJeong
reviewed
Feb 11, 2024
| @@ -60,12 +60,12 @@ export class FreePostCommentsController { | |||
| @SetResponse({ type: ResponseType.Pagination, key: 'freePostComments' }) | |||
| @Get() | |||
| async findAllAndCount( | |||
| @Param('freePostId', ParsePositiveIntPipe) freePostId: number, | |||
| @Param('freePost', ParsePositiveIntPipe) freePost: number, | |||
| putUpdate( | ||
| @User() user: UserDto, | ||
| @Param('freePostId', ParsePositiveIntPipe) freePostId: number, | ||
| @Param('freePostCommentId', ParsePositiveIntPipe) freePostCommentId: number, | ||
| @Param('freePost', ParsePositiveIntPipe) freePost: number, |
| remove( | ||
| @User() user: UserDto, | ||
| @Param('freePostId') freePostId: number, | ||
| @Param('freePostCommentId', ParsePositiveIntPipe) freePostCommentId: number, | ||
| @Param('freePost') freePost: number, |
There was a problem hiding this comment.
이거 postId여야 할 것 같아요
파이프가 빠졌어여
| createReaction( | ||
| @User() user: UserDto, | ||
| @Param('freePostId', ParsePositiveIntPipe) freePostId: number, | ||
| @Param('freePostCommentId', ParsePositiveIntPipe) freePostCommentId: number, | ||
| @Param('freePost', ParsePositiveIntPipe) freePost: number, |
| removeReaction( | ||
| @User() user: UserDto, | ||
| @Param('freePostId', ParsePositiveIntPipe) freePostId: number, | ||
| @Param('freePostCommentId', ParsePositiveIntPipe) freePostCommentId: number, | ||
| @Param('freePost', ParsePositiveIntPipe) freePost: number, |
| @Param('freePostCommentId', ParsePositiveIntPipe) freePostCommentId: number, | ||
| @Param('freePostReplyCommentId', ParsePositiveIntPipe) | ||
| freePostReplyCommentId: number, | ||
| @Param('postId') postId: number, |
rrgks6221
force-pushed
the
refactor/QYOG-73
branch
from
53a0aad to
21576fe
Compare
rrgks6221
force-pushed
the
refactor/QYOG-73
branch
from
21576fe to
baa5bcd
Compare
|
@hobiJeong 꼼꼼한 확인 감사합니다. 수정했어요. |
hobiJeong
approved these changes
Feb 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA
QYOG-73
Description
post 관련 리소스 변수명 간소화
To Reviewer
Reference Link
Related Issue Link
API