FIxed the issues of count determining in the controller.

Author: ruslanbaidan

src/Controller/ApiAnrRolfRisksController.php

@@ -9,6 +9,7 @@
 
 use Laminas\View\Model\JsonModel;
 use Monarc\FrontOffice\Service\AnrRolfRiskService;
+use Monarc\FrontOffice\Model\Entity\Measure;
 
 /**
  * Api ANR Rolf Risks Controller
@@ -26,12 +27,11 @@ public function get($id)
     {
         $entity = $this->getService()->getEntity($id);
 
-        if (count($this->dependencies)) {
-            $this->formatDependencies($entity, $this->dependencies, 'Monarc\FrontOffice\Model\Entity\Measure', ['referential']);
-        }
+        $this->formatDependencies($entity, $this->dependencies, Measure::class, ['referential']);
 
         return new JsonModel($entity);
     }
+
     /**
      * @inheritdoc
      */
@@ -51,7 +51,9 @@ public function getList()
         foreach ($rolfRisks as $key => $rolfRisk) {
 
             if (count($this->dependencies)) {
-                    $this->formatDependencies($rolfRisks[$key], $this->dependencies, 'Monarc\FrontOffice\Model\Entity\Measure', ['referential']);
+                $this->formatDependencies(
+                    $rolfRisks[$key], $this->dependencies, 'Monarc\FrontOffice\Model\Entity\Measure', ['referential']
+                );
             }
 
             $rolfRisk['tags']->initialize();
@@ -64,40 +66,46 @@ public function getList()
 
         return new JsonModel([
             'count' => $service->getFilteredSpecificCount($page, $limit, $order, $filter, $tag, $anr),
-            $this->name => $rolfRisks
+            $this->name => $rolfRisks,
         ]);
     }
 
     public function update($id, $data)
     {
-      if(count($data['measures'])>0)
-        $data['measures'] = $this->addAnrId($data['measures']);
-      return parent::update($id, $data);
+        if (!empty($data['measures'])) {
+            $data['measures'] = $this->addAnrId($data['measures']);
+        }
+
+        return parent::update($id, $data);
     }
 
     public function patch($id, $data)
     {
-      if(count($data['measures'])>0)
-        $data['measures'] = $this->addAnrId($data['measures']);
-      return parent::patch($id, $data);
+        if (!empty($data['measures'])) {
+            $data['measures'] = $this->addAnrId($data['measures']);
+        }
+
+        return parent::patch($id, $data);
     }
 
 
     public function patchList($data)
     {
-      $service = $this->getService();
-      $data['toReferential'] = $this->addAnrId($data['toReferential']);
-      $service->createLinkedRisks($data['fromReferential'],$data['toReferential']);
+        $service = $this->getService();
+        $data['toReferential'] = $this->addAnrId($data['toReferential']);
+        $service->createLinkedRisks($data['fromReferential'], $data['toReferential']);
 
-      return new JsonModel([
-          'status' =>  'ok',
-      ]);
+        return new JsonModel([
+            'status' => 'ok',
+        ]);
     }
 
     public function create($data)
     {
-      if(count($data['measures'])>0)
-        $data['measures'] = $this->addAnrId($data['measures']);
-      return parent::create($data);
+        if (!empty($data['measures'])) {
+            $data['measures'] = $this->addAnrId($data['measures']);
+        }
+
+        return parent::create($data);
     }
 }