Update AnrThreatService.php

ruslanbaidan · web-flow · commit b40bf0a903aa · 2023-08-18T12:44:23.000+02:00
Fixed the threatRate inheritance flag set when instance risks update is enforced.
diff --git a/src/Service/AnrThreatService.php b/src/Service/AnrThreatService.php
@@ -62,7 +62,7 @@ public function manageQualification($id, $data)
             ];
 
             // If qualification is not forced, retrieve only inherited instance risksx
-            if (!isset($data['forceQualification']) || $data['forceQualification'] === 0) {
+            if (empty($data['forceQualification'])) {
                 $filter['mh'] = 1;
             }
 
@@ -77,7 +77,7 @@ public function manageQualification($id, $data)
                 $instanceRisk->threatRate = $data['qualification'];
 
                 // If qualification is forced, instances risks become inherited
-                if (isset($data['forceQualification']) && $data['forceQualification'] === 1) {
+                if (!empty($data['forceQualification'])) {
                     $instanceRisk->mh = 1;
                 }
 

Original file line number	Diff line number	Diff line change
`@@ -62,7 +62,7 @@ public function manageQualification($id, $data)`
`62`	`62`	`];`
`63`	`63`
`64`	`64`	`// If qualification is not forced, retrieve only inherited instance risksx`
`65`		`- if (!isset($data['forceQualification']) \|\| $data['forceQualification'] === 0) {`
	`65`	`+ if (empty($data['forceQualification'])) {`
`66`	`66`	`$filter['mh'] = 1;`
`67`	`67`	`}`
`68`	`68`
`@@ -77,7 +77,7 @@ public function manageQualification($id, $data)`
`77`	`77`	`$instanceRisk->threatRate = $data['qualification'];`
`78`	`78`
`79`	`79`	`// If qualification is forced, instances risks become inherited`
`80`		`- if (isset($data['forceQualification']) && $data['forceQualification'] === 1) {`
	`80`	`+ if (!empty($data['forceQualification'])) {`
`81`	`81`	`$instanceRisk->mh = 1;`
`82`	`82`	`}`
`83`	`83`