Fix #251: Add option to disable signature verification #255
+55
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Running this locally, I think it seems fine. I kept trying to think of a good way to combine this Options section with the Environment section since it's just one checkbox. Maybe call it "Configuration"? Can approve after lint error is fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #251
I am not convinced about the approach, but also can't think of anything better...
In Gecko, signature verification can be enabled/disabled at the collection object level.
From a DevTools/UI/UX point of view, I don't see any value in offering the option to enable/disable for each collection. So I decided to go for a global switch.
This has one small disavantage: user clicks disable. It's disabled for all instantiated clients. A new client is instantiated (manually or within a component firefox). It has signature enabled. UI shows enabled again. User has to click to disable again.
And also:
<div>but CSS to organize UI